[webkit-changes] [288912] trunk/Source/WebCore

Tue, 01 Feb 2022 14:13:55 -0800

Title: [288912] trunk/Source/WebCore
Revision
288912
Author
[email protected]
Date
2022-02-01 14:13:05 -0800 (Tue, 01 Feb 2022)

Log Message

Use more AtomString and un-inline code for ScriptElementCachedScriptFetcher and its subclasses
https://bugs.webkit.org/show_bug.cgi?id=235919
<rdar://problem/88338714>

Address Darin's review comment. nonce in LoadableClassicScript's constructor should also have been
converted to AtomString in r288900.

* dom/LoadableClassicScript.cpp:
(WebCore::LoadableClassicScript::LoadableClassicScript):
* dom/LoadableClassicScript.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (288911 => 288912)


--- trunk/Source/WebCore/ChangeLog	2022-02-01 21:51:21 UTC (rev 288911)
+++ trunk/Source/WebCore/ChangeLog	2022-02-01 22:13:05 UTC (rev 288912)
@@ -1,3 +1,16 @@
+2022-02-01  Ryosuke Niwa  <[email protected]>
+
+        Use more AtomString and un-inline code for ScriptElementCachedScriptFetcher and its subclasses
+        https://bugs.webkit.org/show_bug.cgi?id=235919
+        <rdar://problem/88338714>
+
+        Address Darin's review comment. nonce in LoadableClassicScript's constructor should also have been
+        converted to AtomString in r288900.
+
+        * dom/LoadableClassicScript.cpp:
+        (WebCore::LoadableClassicScript::LoadableClassicScript):
+        * dom/LoadableClassicScript.h:
+
 2022-02-01  Antoine Quint  <[email protected]>
 
         Refactor KeyframesRuleMap to use AtomString for the key

Modified: trunk/Source/WebCore/dom/LoadableClassicScript.cpp (288911 => 288912)


--- trunk/Source/WebCore/dom/LoadableClassicScript.cpp	2022-02-01 21:51:21 UTC (rev 288911)
+++ trunk/Source/WebCore/dom/LoadableClassicScript.cpp	2022-02-01 22:13:05 UTC (rev 288912)
@@ -41,7 +41,7 @@
     return adoptRef(*new LoadableClassicScript(nonce, integrityMetadata, policy, crossOriginMode, charset, initiatorName, isInUserAgentShadowTree, isAsync));
 }
 
-LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)
+LoadableClassicScript::LoadableClassicScript(const AtomString& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)
     : LoadableScript(nonce, policy, crossOriginMode, charset, initiatorName, isInUserAgentShadowTree)
     , m_integrity(integrity)
     , m_isAsync(isAsync)

Modified: trunk/Source/WebCore/dom/LoadableClassicScript.h (288911 => 288912)


--- trunk/Source/WebCore/dom/LoadableClassicScript.h	2022-02-01 21:51:21 UTC (rev 288911)
+++ trunk/Source/WebCore/dom/LoadableClassicScript.h	2022-02-01 22:13:05 UTC (rev 288912)
@@ -56,7 +56,7 @@
     bool load(Document&, const URL&);
 
 private:
-    LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync);
+    LoadableClassicScript(const AtomString& nonce, const AtomString& integrity, ReferrerPolicy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync);
 
     void notifyFinished(CachedResource&, const NetworkLoadMetrics&) final;
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to