Title: [288930] trunk/Source
Revision
288930
Author
[email protected]
Date
2022-02-01 17:18:04 -0800 (Tue, 01 Feb 2022)

Log Message

Add setting to toggle PDF.js viewer
https://bugs.webkit.org/show_bug.cgi?id=235972

Reviewed by Tim Horton.

This setting is enabled only in CaptivePortalMode.

Source/WebKit:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WTF:

* Scripts/Preferences/WebPreferencesInternal.yaml:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (288929 => 288930)


--- trunk/Source/WTF/ChangeLog	2022-02-02 00:47:27 UTC (rev 288929)
+++ trunk/Source/WTF/ChangeLog	2022-02-02 01:18:04 UTC (rev 288930)
@@ -1,3 +1,14 @@
+2022-02-01  Tim Nguyen  <[email protected]>
+
+        Add setting to toggle PDF.js viewer
+        https://bugs.webkit.org/show_bug.cgi?id=235972
+
+        Reviewed by Tim Horton.
+
+        This setting is enabled only in CaptivePortalMode.
+
+        * Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2022-02-01  Pablo Saavedra  <[email protected]>
 
         [GTK][WPE] Fixes for non-unified builds after r288807 and r288820

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (288929 => 288930)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-02-02 00:47:27 UTC (rev 288929)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2022-02-02 01:18:04 UTC (rev 288930)
@@ -649,6 +649,18 @@
       "ENABLE(EXPERIMENTAL_FEATURES) && (PLATFORM(GTK) || PLATFORM(WPE))": true
       default: false
 
+PdfJSViewerEnabled:
+  type: bool
+  humanReadableName: "Enable PDF.js viewer"
+  humanReadableDescription: "Enable PDF.js viewer"
+  defaultValue:
+    WebKitLegacy:
+      default: false
+    WebKit:
+      default: false
+    WebCore:
+      default: false
+
 PreferFasterClickOverDoubleTap:
   type: bool
   humanReadableName: "Fast clicks beat DTTZ"

Modified: trunk/Source/WebKit/ChangeLog (288929 => 288930)


--- trunk/Source/WebKit/ChangeLog	2022-02-02 00:47:27 UTC (rev 288929)
+++ trunk/Source/WebKit/ChangeLog	2022-02-02 01:18:04 UTC (rev 288930)
@@ -1,3 +1,15 @@
+2022-02-01  Tim Nguyen  <[email protected]>
+
+        Add setting to toggle PDF.js viewer
+        https://bugs.webkit.org/show_bug.cgi?id=235972
+
+        Reviewed by Tim Horton.
+
+        This setting is enabled only in CaptivePortalMode.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+
 2022-02-01  Ben Nham  <[email protected]>
 
         Forward messages from NetworkProcess to webpushd

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (288929 => 288930)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-02-02 00:47:27 UTC (rev 288929)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2022-02-02 01:18:04 UTC (rev 288930)
@@ -4107,6 +4107,7 @@
 #if ENABLE(MATHML)
         settings.setMathMLEnabled(false);
 #endif
+        settings.setPdfJSViewerEnabled(true);
     }
 
 #if ENABLE(ARKIT_INLINE_PREVIEW)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to