Title: [288964] trunk/Source/WebCore
- Revision
- 288964
- Author
- [email protected]
- Date
- 2022-02-02 10:44:21 -0800 (Wed, 02 Feb 2022)
Log Message
CSSPropertyAnimation::animatableShorthandsAffectingProperty() is unused
https://bugs.webkit.org/show_bug.cgi?id=236022
Reviewed by Dean Jackson.
This method is a remnant from the legacy animation engine and should be removed.
* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty): Deleted.
* animation/CSSPropertyAnimation.h:
* animation/CSSPropertyAnimation.cpp:
(WebCore::gatherEnclosingShorthandProperties): Deleted.
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty): Deleted.
* animation/CSSPropertyAnimation.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288963 => 288964)
--- trunk/Source/WebCore/ChangeLog 2022-02-02 18:42:28 UTC (rev 288963)
+++ trunk/Source/WebCore/ChangeLog 2022-02-02 18:44:21 UTC (rev 288964)
@@ -1,3 +1,21 @@
+2022-02-02 Antoine Quint <[email protected]>
+
+ CSSPropertyAnimation::animatableShorthandsAffectingProperty() is unused
+ https://bugs.webkit.org/show_bug.cgi?id=236022
+
+ Reviewed by Dean Jackson.
+
+ This method is a remnant from the legacy animation engine and should be removed.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty): Deleted.
+ * animation/CSSPropertyAnimation.h:
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::gatherEnclosingShorthandProperties): Deleted.
+ (WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty): Deleted.
+ * animation/CSSPropertyAnimation.h:
+
2022-02-02 Andres Gonzalez <[email protected]>
Make modifications to the isolated Tree atomic.
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (288963 => 288964)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-02-02 18:42:28 UTC (rev 288963)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-02-02 18:44:21 UTC (rev 288964)
@@ -2870,24 +2870,6 @@
}
}
-static bool gatherEnclosingShorthandProperties(CSSPropertyID property, AnimationPropertyWrapperBase* wrapper, HashSet<CSSPropertyID>& propertySet)
-{
- if (!wrapper->isShorthandWrapper())
- return false;
-
- ShorthandPropertyWrapper* shorthandWrapper = static_cast<ShorthandPropertyWrapper*>(wrapper);
- bool contained = false;
- for (auto& currWrapper : shorthandWrapper->propertyWrappers()) {
- if (gatherEnclosingShorthandProperties(property, currWrapper, propertySet) || currWrapper->property() == property)
- contained = true;
- }
-
- if (contained)
- propertySet.add(wrapper->property());
-
- return contained;
-}
-
void CSSPropertyAnimation::blendProperties(const CSSPropertyBlendingClient* client, CSSPropertyID property, RenderStyle& destination, const RenderStyle& from, const RenderStyle& to, double progress, CompositeOperation compositeOperation)
{
ASSERT(property != CSSPropertyInvalid);
@@ -2927,18 +2909,6 @@
return wrapper ? wrapper->animationIsAccelerated() : false;
}
-// Note: this is inefficient. It's only called from pauseTransitionAtTime().
-HashSet<CSSPropertyID> CSSPropertyAnimation::animatableShorthandsAffectingProperty(CSSPropertyID property)
-{
- CSSPropertyAnimationWrapperMap& map = CSSPropertyAnimationWrapperMap::singleton();
-
- HashSet<CSSPropertyID> foundProperties;
- for (unsigned i = 0; i < map.size(); ++i)
- gatherEnclosingShorthandProperties(property, map.wrapperForIndex(i), foundProperties);
-
- return foundProperties;
-}
-
bool CSSPropertyAnimation::propertiesEqual(CSSPropertyID property, const RenderStyle& a, const RenderStyle& b)
{
AnimationPropertyWrapperBase* wrapper = CSSPropertyAnimationWrapperMap::singleton().wrapperForProperty(property);
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.h (288963 => 288964)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.h 2022-02-02 18:42:28 UTC (rev 288963)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.h 2022-02-02 18:44:21 UTC (rev 288964)
@@ -47,8 +47,6 @@
static CSSPropertyID getPropertyAtIndex(int, std::optional<bool>& isShorthand);
static int getNumProperties();
- static HashSet<CSSPropertyID> animatableShorthandsAffectingProperty(CSSPropertyID);
-
static void blendProperties(const CSSPropertyBlendingClient*, CSSPropertyID, RenderStyle& destination, const RenderStyle& from, const RenderStyle& to, double progress, CompositeOperation);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
