Title: [289017] trunk/Source
- Revision
- 289017
- Author
- [email protected]
- Date
- 2022-02-02 16:56:01 -0800 (Wed, 02 Feb 2022)
Log Message
[Xcode] Fix redundant execution of "Check VTables..." script
https://bugs.webkit.org/show_bug.cgi?id=236032
Patch by Elliott Williams <[email protected]> on 2022-02-02
Reviewed by Jonathan Bedard.
Source/_javascript_Core:
Tools/Scripts/check-for-weak-vtables-and-externals already touches a timestamp file after
every execution. Add it as an output file to all "Check For Weak VTables and Externals"
script phases.
These script phases already list their respective executables as inputs. This change shaves
a few seconds off the null build time.
* _javascript_Core.xcodeproj/project.pbxproj: Add timestamp file to script phase.
Source/ThirdParty/libwebrtc:
* libwebrtc.xcodeproj/project.pbxproj: Add timestamp file to script phase.
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj: Add timestamp file to script phase.
Source/WebKitLegacy:
* WebKitLegacy.xcodeproj/project.pbxproj: Add timestamp file to script phase.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (289016 => 289017)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-03 00:56:01 UTC (rev 289017)
@@ -1,3 +1,19 @@
+2022-02-02 Elliott Williams <[email protected]>
+
+ [Xcode] Fix redundant execution of "Check VTables..." script
+ https://bugs.webkit.org/show_bug.cgi?id=236032
+
+ Reviewed by Jonathan Bedard.
+
+ Tools/Scripts/check-for-weak-vtables-and-externals already touches a timestamp file after
+ every execution. Add it as an output file to all "Check For Weak VTables and Externals"
+ script phases.
+
+ These script phases already list their respective executables as inputs. This change shaves
+ a few seconds off the null build time.
+
+ * _javascript_Core.xcodeproj/project.pbxproj: Add timestamp file to script phase.
+
2022-02-02 Yusuke Suzuki <[email protected]>
[JSC] Crash on several pages after r287986
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (289016 => 289017)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2022-02-03 00:56:01 UTC (rev 289017)
@@ -11860,6 +11860,7 @@
);
name = "Check For Weak VTables and Externals";
outputPaths = (
+ "$(TARGET_TEMP_DIR)/check-for-weak-vtables-and-externals.timestamp",
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (289016 => 289017)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2022-02-03 00:56:01 UTC (rev 289017)
@@ -1,3 +1,12 @@
+2022-02-02 Elliott Williams <[email protected]>
+
+ [Xcode] Fix redundant execution of "Check VTables..." script
+ https://bugs.webkit.org/show_bug.cgi?id=236032
+
+ Reviewed by Jonathan Bedard.
+
+ * libwebrtc.xcodeproj/project.pbxproj: Add timestamp file to script phase.
+
2022-02-02 Youenn Fablet <[email protected]>
LibWebRTCCodecs should not need to create IOSurfaces
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (289016 => 289017)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2022-02-03 00:56:01 UTC (rev 289017)
@@ -17506,10 +17506,11 @@
);
name = "Check for Weak VTables and Externals";
outputPaths = (
+ "$(TARGET_TEMP_DIR)/check-for-weak-vtables-and-externals.timestamp",
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n ../../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+ shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n ../../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi\n";
};
659A86EA279796F800AC37B6 /* Create Symlink to Alt Root Path */ = {
isa = PBXShellScriptBuildPhase;
Modified: trunk/Source/WebKit/ChangeLog (289016 => 289017)
--- trunk/Source/WebKit/ChangeLog 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/WebKit/ChangeLog 2022-02-03 00:56:01 UTC (rev 289017)
@@ -1,3 +1,12 @@
+2022-02-02 Elliott Williams <[email protected]>
+
+ [Xcode] Fix redundant execution of "Check VTables..." script
+ https://bugs.webkit.org/show_bug.cgi?id=236032
+
+ Reviewed by Jonathan Bedard.
+
+ * WebKit.xcodeproj/project.pbxproj: Add timestamp file to script phase.
+
2022-02-02 Sihui Liu <[email protected]>
Remove OriginStorageManager if it's not in use
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (289016 => 289017)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-02-03 00:56:01 UTC (rev 289017)
@@ -14960,6 +14960,7 @@
);
name = "Check For Weak VTables and Externals";
outputPaths = (
+ "$(TARGET_TEMP_DIR)/check-for-weak-vtables-and-externals.timestamp",
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
Modified: trunk/Source/WebKitLegacy/ChangeLog (289016 => 289017)
--- trunk/Source/WebKitLegacy/ChangeLog 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/WebKitLegacy/ChangeLog 2022-02-03 00:56:01 UTC (rev 289017)
@@ -1,3 +1,12 @@
+2022-02-02 Elliott Williams <[email protected]>
+
+ [Xcode] Fix redundant execution of "Check VTables..." script
+ https://bugs.webkit.org/show_bug.cgi?id=236032
+
+ Reviewed by Jonathan Bedard.
+
+ * WebKitLegacy.xcodeproj/project.pbxproj: Add timestamp file to script phase.
+
2022-02-02 Youenn Fablet <[email protected]>
Clarify that some UUID routines are dedicated to UUID v4
Modified: trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj (289016 => 289017)
--- trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2022-02-03 00:48:32 UTC (rev 289016)
+++ trunk/Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj 2022-02-03 00:56:01 UTC (rev 289017)
@@ -3305,10 +3305,11 @@
);
name = "Check For Weak VTables and Externals";
outputPaths = (
+ "$(TARGET_TEMP_DIR)/check-for-weak-vtables-and-externals.timestamp",
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+ shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi\n";
};
5D2F7DB70C687A5A00B5B72B /* Update Info.plist with version information */ = {
isa = PBXShellScriptBuildPhase;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
