Title: [289042] trunk/Tools
Revision
289042
Author
[email protected]
Date
2022-02-03 05:11:01 -0800 (Thu, 03 Feb 2022)

Log Message

WebDriver: selenium tests are executed more than once
https://bugs.webkit.org/show_bug.cgi?id=236075

Reviewed by Darin Adler.

I think this happens since we updated the pytest version. Pytest is now collecting test files that don't
contain any test like __init__.py files. When that's given to the runner all the tests under the directory are
executed.

* Scripts/webkitpy/webdriver_tests/pytest_runner.py:
(CollectRecorder.pytest_collectreport): Do not include files with no tests.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (289041 => 289042)


--- trunk/Tools/ChangeLog	2022-02-03 13:06:49 UTC (rev 289041)
+++ trunk/Tools/ChangeLog	2022-02-03 13:11:01 UTC (rev 289042)
@@ -1,3 +1,17 @@
+2022-02-03  Carlos Garcia Campos  <[email protected]>
+
+        WebDriver: selenium tests are executed more than once
+        https://bugs.webkit.org/show_bug.cgi?id=236075
+
+        Reviewed by Darin Adler.
+
+        I think this happens since we updated the pytest version. Pytest is now collecting test files that don't
+        contain any test like __init__.py files. When that's given to the runner all the tests under the directory are
+        executed.
+
+        * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
+        (CollectRecorder.pytest_collectreport): Do not include files with no tests.
+
 2022-02-03  Myles C. Maxfield  <[email protected]>
 
         Allow using STIX Two in layout tests

Modified: trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py (289041 => 289042)


--- trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py	2022-02-03 13:06:49 UTC (rev 289041)
+++ trunk/Tools/Scripts/webkitpy/webdriver_tests/pytest_runner.py	2022-02-03 13:11:01 UTC (rev 289042)
@@ -70,7 +70,7 @@
         self.tests = {}
 
     def pytest_collectreport(self, report):
-        if report.nodeid:
+        if report.nodeid and report.result:
             self.tests.setdefault(report.nodeid, [])
             for subtest in report.result:
                 self.tests[report.nodeid].append(get_item_name(subtest, self._ignore_param))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to