Title: [289163] trunk/Source/WebCore
- Revision
- 289163
- Author
- [email protected]
- Date
- 2022-02-05 15:42:27 -0800 (Sat, 05 Feb 2022)
Log Message
[LBSE] Handle RenderSVGShape in SVGRenderSupport::applyStrokeStyleToContext()
https://bugs.webkit.org/show_bug.cgi?id=236077
Reviewed by Darin Adler.
Activate path length calculation for RenderSVGShape -- this bit
was missing when the layer-aware RenderSVGShape implementation was
upstreamed in r287832.
Currently the functionality is not observable, as we don't create
LBSE renderers yet.
Covered by existing tests, no change in behaviour.
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289162 => 289163)
--- trunk/Source/WebCore/ChangeLog 2022-02-05 23:39:04 UTC (rev 289162)
+++ trunk/Source/WebCore/ChangeLog 2022-02-05 23:42:27 UTC (rev 289163)
@@ -1,3 +1,22 @@
+2022-02-03 Nikolas Zimmermann <[email protected]>
+
+ [LBSE] Handle RenderSVGShape in SVGRenderSupport::applyStrokeStyleToContext()
+ https://bugs.webkit.org/show_bug.cgi?id=236077
+
+ Reviewed by Darin Adler.
+
+ Activate path length calculation for RenderSVGShape -- this bit
+ was missing when the layer-aware RenderSVGShape implementation was
+ upstreamed in r287832.
+
+ Currently the functionality is not observable, as we don't create
+ LBSE renderers yet.
+
+ Covered by existing tests, no change in behaviour.
+
+ * rendering/svg/SVGRenderSupport.cpp:
+ (WebCore::SVGRenderSupport::applyStrokeStyleToContext):
+
2022-02-05 Antoine Quint <[email protected]>
[CSS transition] can't use CSS logical properties in transition syntax
Modified: trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp (289162 => 289163)
--- trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2022-02-05 23:39:04 UTC (rev 289162)
+++ trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp 2022-02-05 23:42:27 UTC (rev 289163)
@@ -42,6 +42,7 @@
#include "RenderSVGResourceMarker.h"
#include "RenderSVGResourceMasker.h"
#include "RenderSVGRoot.h"
+#include "RenderSVGShape.h"
#include "RenderSVGText.h"
#include "RenderSVGTransformableContainer.h"
#include "RenderSVGViewportContainer.h"
@@ -486,7 +487,10 @@
if (float pathLength = downcast<SVGGeometryElement>(element)->pathLength()) {
if (is<LegacyRenderSVGShape>(renderer))
scaleFactor = downcast<LegacyRenderSVGShape>(renderer).getTotalLength() / pathLength;
- // FIXME: [LBSE] Upstream RenderSVGShape
+#if ENABLE(LAYER_BASED_SVG_ENGINE)
+ else if (is<RenderSVGShape>(renderer))
+ scaleFactor = downcast<RenderSVGShape>(renderer).getTotalLength() / pathLength;
+#endif
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
