Title: [289168] trunk/Source/WebCore
- Revision
- 289168
- Author
- [email protected]
- Date
- 2022-02-06 07:39:56 -0800 (Sun, 06 Feb 2022)
Log Message
[css-transitions] remove duplicate code dealing with completed transitions
https://bugs.webkit.org/show_bug.cgi?id=236198
Reviewed by Dean Jackson.
We already mark transitions as completed in DocumentTimeline::transitionDidComplete()
and doing this again in updateCSSTransitionsForStyleableAndProperty() is unnecessary.
* style/Styleable.cpp:
(WebCore::updateCSSTransitionsForStyleableAndProperty):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289167 => 289168)
--- trunk/Source/WebCore/ChangeLog 2022-02-06 15:17:32 UTC (rev 289167)
+++ trunk/Source/WebCore/ChangeLog 2022-02-06 15:39:56 UTC (rev 289168)
@@ -1,5 +1,18 @@
2022-02-06 Antoine Quint <[email protected]>
+ [css-transitions] remove duplicate code dealing with completed transitions
+ https://bugs.webkit.org/show_bug.cgi?id=236198
+
+ Reviewed by Dean Jackson.
+
+ We already mark transitions as completed in DocumentTimeline::transitionDidComplete()
+ and doing this again in updateCSSTransitionsForStyleableAndProperty() is unnecessary.
+
+ * style/Styleable.cpp:
+ (WebCore::updateCSSTransitionsForStyleableAndProperty):
+
+2022-02-06 Antoine Quint <[email protected]>
+
[css-logical] [css-transitions] Resolve logic properties when compiling the list of transition properties
https://bugs.webkit.org/show_bug.cgi?id=236197
Modified: trunk/Source/WebCore/style/Styleable.cpp (289167 => 289168)
--- trunk/Source/WebCore/style/Styleable.cpp 2022-02-06 15:17:32 UTC (rev 289167)
+++ trunk/Source/WebCore/style/Styleable.cpp 2022-02-06 15:39:56 UTC (rev 289168)
@@ -416,13 +416,6 @@
}
}
- // A CSS Transition might have completed since the last time animations were updated so we must
- // update the running and completed transitions membership in that case.
- if (is<CSSTransition>(animation) && matchingBackingAnimation && styleable.hasRunningTransitionForProperty(property) && animation->playState() == WebAnimation::PlayState::Finished) {
- styleable.ensureCompletedTransitionsByProperty().set(property, styleable.ensureRunningTransitionsByProperty().take(property));
- animation = nullptr;
- }
-
// https://drafts.csswg.org/css-transitions-1/#before-change-style
// Define the before-change style as the computed values of all properties on the element as of the previous style change event, except with
// any styles derived from declarative animations such as CSS Transitions, CSS Animations, and SMIL Animations updated to the current time.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
