Diff
Modified: trunk/Source/WTF/ChangeLog (289169 => 289170)
--- trunk/Source/WTF/ChangeLog 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WTF/ChangeLog 2022-02-06 17:33:55 UTC (rev 289170)
@@ -1,3 +1,12 @@
+2022-02-06 Tyler Wilcock <[email protected]>
+
+ AX: Add internal-only flag to enable WIP display: contents support
+ https://bugs.webkit.org/show_bug.cgi?id=236179
+
+ Reviewed by Chris Fleizach.
+
+ * Scripts/Preferences/WebPreferencesInternal.yaml:
+
2022-02-05 David Kilzer <[email protected]>
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (289169 => 289170)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-02-06 17:33:55 UTC (rev 289170)
@@ -122,6 +122,17 @@
WebCore:
default: false
+CSSDisplayContentsAXSupportEnabled:
+ type: bool
+ humanReadableName: "Accessibility support for display: contents elements"
+ humanReadableDescription: "Enable work-in-progress accessibility support for display: contents elements"
+ webcoreBinding: RuntimeEnabledFeatures
+ defaultValue:
+ WebKitLegacy:
+ default: false
+ WebKit:
+ default: false
+
CSSLogicalEnabled:
type: bool
humanReadableName: "CSS Logical Properties and Values"
Modified: trunk/Source/WebCore/ChangeLog (289169 => 289170)
--- trunk/Source/WebCore/ChangeLog 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebCore/ChangeLog 2022-02-06 17:33:55 UTC (rev 289170)
@@ -1,3 +1,19 @@
+2022-02-06 Tyler Wilcock <[email protected]>
+
+ AX: Add internal-only flag to enable WIP display: contents support
+ https://bugs.webkit.org/show_bug.cgi?id=236179
+
+ Reviewed by Chris Fleizach.
+
+ Shipping half-done accessibility support for display: contents will
+ probably be a worse experience than status quo in some scenarios, so
+ we should gate it behind an internal-only feature flag until we're
+ confident it's ready.
+
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled):
+ (WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const):
+
2022-02-06 Antoine Quint <[email protected]>
[css-transitions] remove duplicate code dealing with completed transitions
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (289169 => 289170)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2022-02-06 17:33:55 UTC (rev 289170)
@@ -169,6 +169,9 @@
void setServiceWorkerEnabled(bool isEnabled) { m_serviceWorkerEnabled = isEnabled; }
#endif
+ void setCSSDisplayContentsAXSupportEnabled(bool isEnabled) { m_CSSDisplayContentsAXSupportEnabled = isEnabled; }
+ bool cssDisplayContentsAXSupportEnabled() const { return m_CSSDisplayContentsAXSupportEnabled; }
+
void setCSSLogicalEnabled(bool isEnabled) { m_CSSLogicalEnabled = isEnabled; }
bool cssLogicalEnabled() const { return m_CSSLogicalEnabled; }
@@ -334,6 +337,7 @@
bool m_serviceWorkerEnabled { false };
#endif
+ bool m_CSSDisplayContentsAXSupportEnabled { false };
bool m_CSSLogicalEnabled { false };
// False by default until https://bugs.webkit.org/show_bug.cgi?id=211351 /
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (289169 => 289170)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2022-02-06 17:33:55 UTC (rev 289170)
@@ -1,3 +1,16 @@
+2022-02-06 Tyler Wilcock <[email protected]>
+
+ AX: Add internal-only flag to enable WIP display: contents support
+ https://bugs.webkit.org/show_bug.cgi?id=236179
+
+ Reviewed by Chris Fleizach.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (-[WebPreferences cssDisplayContentsAXSupportEnabled]):
+ (-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+
2022-02-03 Ryosuke Niwa <[email protected]>
Delete SelectionAcrossShadowBoundariesEnabled
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (289169 => 289170)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2022-02-06 17:33:55 UTC (rev 289170)
@@ -241,6 +241,7 @@
#define WebKitInspectorAdditionsEnabledPreferenceKey @"WebKitInspectorAdditionsEnabled"
#define WebKitAriaReflectionEnabledPreferenceKey @"WebKitAriaReflectionEnabled"
#define WebKitMediaCapabilitiesEnabledPreferenceKey @"WebKitMediaCapabilitiesEnabled"
+#define WebKitCSSDisplayContentsAXSupportEnabledPreferenceKey @"WebKitCSSDisplayContentsAXSupportEnabled"
#define WebKitCSSLogicalEnabledPreferenceKey @"WebKitCSSLogicalEnabled"
#define WebKitLineHeightUnitsEnabledPreferenceKey @"WebKitLineHeightUnitsEnabled"
#define WebKitDebugInAppBrowserPrivacyEnabledPreferenceKey @"WebKitDebugInAppBrowserPrivacyEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (289169 => 289170)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2022-02-06 17:33:55 UTC (rev 289170)
@@ -2880,6 +2880,16 @@
[self _setBoolValue:flag forKey:WebKitMediaCapabilitiesEnabledPreferenceKey];
}
+- (BOOL)cssDisplayContentsAXSupportEnabled
+{
+ return [self _boolValueForKey:WebKitCSSDisplayContentsAXSupportEnabledPreferenceKey];
+}
+
+- (void)setCSSDisplayContentsAXSupportEnabled:(BOOL)flag
+{
+ [self _setBoolValue:flag forKey:WebKitCSSDisplayContentsAXSupportEnabledPreferenceKey];
+}
+
- (BOOL)cssLogicalEnabled
{
return [self _boolValueForKey:WebKitCSSLogicalEnabledPreferenceKey];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (289169 => 289170)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2022-02-06 17:33:55 UTC (rev 289170)
@@ -225,6 +225,7 @@
@property (nonatomic) BOOL cacheAPIEnabled;
@property (nonatomic) BOOL downloadAttributeEnabled;
@property (nonatomic) BOOL directoryUploadEnabled;
+@property (nonatomic, getter=cssDisplayContentsAXSupportEnabled) BOOL CSSDisplayContentsAXSupportEnabled;
@property (nonatomic, getter=cssLogicalEnabled) BOOL CSSLogicalEnabled;
@property (nonatomic) BOOL lineHeightUnitsEnabled;
@property (nonatomic) BOOL layoutFormattingContextIntegrationEnabled;
Modified: trunk/Tools/ChangeLog (289169 => 289170)
--- trunk/Tools/ChangeLog 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Tools/ChangeLog 2022-02-06 17:33:55 UTC (rev 289170)
@@ -1,3 +1,13 @@
+2022-02-06 Tyler Wilcock <[email protected]>
+
+ AX: Add internal-only flag to enable WIP display: contents support
+ https://bugs.webkit.org/show_bug.cgi?id=236179
+
+ Reviewed by Chris Fleizach.
+
+ * DumpRenderTree/TestOptions.cpp:
+ (WTR::TestOptions::defaults):
+
2022-02-06 Wenson Hsieh <[email protected]>
Adjust `platformResetStateToConsistentValues` to avoid grabbing the general pasteboard when possible
Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (289169 => 289170)
--- trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-02-06 16:14:09 UTC (rev 289169)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-02-06 17:33:55 UTC (rev 289170)
@@ -135,6 +135,7 @@
{ "CSSContainmentEnabled", false },
{ "CSSCounterStyleAtRuleImageSymbolsEnabled", false },
{ "CSSCounterStyleAtRulesEnabled", false },
+ { "CSSDisplayContentsAXSupportEnabled", false },
{ "CSSGradientInterpolationColorSpacesEnabled", true },
{ "CSSGradientPremultipliedAlphaInterpolationEnabled", true },
{ "CSSInputSecurityEnabled", true },
