Title: [289197] trunk/Tools
- Revision
- 289197
- Author
- hironori.fu...@sony.com
- Date
- 2022-02-06 20:42:03 -0800 (Sun, 06 Feb 2022)
Log Message
REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python
https://bugs.webkit.org/show_bug.cgi?id=236043
<rdar://problem/88449289>
Reviewed by Darin Adler.
Since r288878 started to use pyfakefs, Port.relative_test_filename
didn't work as expected in unit tests with Windows Python because
TestPort.layout_tests_dir returned Unix-style path while the path
name of layout test is Windows-style path.
* Scripts/webkitpy/port/test.py: Use abspath to convert Unix-style
path to Windows-style for Windows Python.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (289196 => 289197)
--- trunk/Tools/ChangeLog 2022-02-07 04:18:01 UTC (rev 289196)
+++ trunk/Tools/ChangeLog 2022-02-07 04:42:03 UTC (rev 289197)
@@ -1,3 +1,19 @@
+2022-02-06 Fujii Hironori <hironori.fu...@sony.com>
+
+ REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python
+ https://bugs.webkit.org/show_bug.cgi?id=236043
+ <rdar://problem/88449289>
+
+ Reviewed by Darin Adler.
+
+ Since r288878 started to use pyfakefs, Port.relative_test_filename
+ didn't work as expected in unit tests with Windows Python because
+ TestPort.layout_tests_dir returned Unix-style path while the path
+ name of layout test is Windows-style path.
+
+ * Scripts/webkitpy/port/test.py: Use abspath to convert Unix-style
+ path to Windows-style for Windows Python.
+
2022-02-06 Yusuke Suzuki <ysuz...@apple.com>
[WTF] Make Bitmap constexpr friendly
Modified: trunk/Tools/Scripts/webkitpy/port/test.py (289196 => 289197)
--- trunk/Tools/Scripts/webkitpy/port/test.py 2022-02-07 04:18:01 UTC (rev 289196)
+++ trunk/Tools/Scripts/webkitpy/port/test.py 2022-02-07 04:42:03 UTC (rev 289197)
@@ -441,10 +441,10 @@
return ImageDiffResult(passed=True, diff_image=None, difference=0, tolerance=tolerance or 0, fuzzy_data={'max_difference': 0, 'total_pixels': 0})
def layout_tests_dir(self):
- return LAYOUT_TEST_DIR
+ return self._filesystem.abspath(LAYOUT_TEST_DIR)
def perf_tests_dir(self):
- return PERF_TEST_DIR
+ return self._filesystem.abspath(PERF_TEST_DIR)
def webkit_base(self):
return '/test.checkout'
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
