Title: [289200] trunk/Source/WebKit
- Revision
- 289200
- Author
- [email protected]
- Date
- 2022-02-06 21:45:40 -0800 (Sun, 06 Feb 2022)
Log Message
REGRESSION(r286936): Crash in WebKit::OriginStorageManager::StorageBucket::deleteLocalStorageData
https://bugs.webkit.org/show_bug.cgi?id=236209
Reviewed by Darin Adler.
Add null check for modificationTime returned by FileSystem::fileModificationTime.
* NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::deleteLocalStorageData):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (289199 => 289200)
--- trunk/Source/WebKit/ChangeLog 2022-02-07 05:29:35 UTC (rev 289199)
+++ trunk/Source/WebKit/ChangeLog 2022-02-07 05:45:40 UTC (rev 289200)
@@ -1,3 +1,15 @@
+2022-02-06 Sihui Liu <[email protected]>
+
+ REGRESSION(r286936): Crash in WebKit::OriginStorageManager::StorageBucket::deleteLocalStorageData
+ https://bugs.webkit.org/show_bug.cgi?id=236209
+
+ Reviewed by Darin Adler.
+
+ Add null check for modificationTime returned by FileSystem::fileModificationTime.
+
+ * NetworkProcess/storage/OriginStorageManager.cpp:
+ (WebKit::OriginStorageManager::StorageBucket::deleteLocalStorageData):
+
2022-02-05 Simon Fraser <[email protected]>
Refactor RemoteLayerBackingStoreCollection to have a single backing store traversal function
Modified: trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp (289199 => 289200)
--- trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp 2022-02-07 05:29:35 UTC (rev 289199)
+++ trunk/Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp 2022-02-07 05:45:40 UTC (rev 289200)
@@ -246,7 +246,7 @@
void deleteLocalStorageData(WallTime time)
{
- if (auto modificationTime = FileSystem::fileModificationTime(m_localStoragePath); *modificationTime >= time) {
+ if (FileSystem::fileModificationTime(m_localStoragePath) >= time) {
if (m_localStorageManager)
m_localStorageManager->clearDataOnDisk();
WebCore::SQLiteFileSystem::deleteDatabaseFile(m_localStoragePath);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
