Diff
Modified: trunk/Source/WebCore/ChangeLog (289218 => 289219)
--- trunk/Source/WebCore/ChangeLog 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/ChangeLog 2022-02-07 15:30:26 UTC (rev 289219)
@@ -1,3 +1,27 @@
+2022-02-07 Martin Robinson <[email protected]>
+
+ Fix some compilation warnings coming from unhandled execution paths for unexpected enum values
+ https://bugs.webkit.org/show_bug.cgi?id=236228
+
+ Reviewed by Darin Adler.
+
+ No new tests. This should not change behavior.
+
+ * animation/CompositeOperationOrAuto.h:
+ (WebCore::toCompositeOperationOrAuto):
+ * bindings/js/JSCSSStyleValueCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * bindings/js/JSCSSTransformComponentCustom.cpp:
+ (WebCore::toJSNewlyCreated):
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::valueForAnimationComposition):
+ * css/CSSUnits.cpp:
+ (WebCore::unitCategory):
+ (WebCore::canonicalUnitTypeForCategory):
+ * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+ (WebCore::LibWebRTCProvider::receiverCapabilities):
+ (WebCore::LibWebRTCProvider::senderCapabilities):
+
2022-02-07 Antoine Quint <[email protected]>
[css-logical] [web-animations] Add support for logical properties in JS-originated animations
Modified: trunk/Source/WebCore/animation/CompositeOperationOrAuto.h (289218 => 289219)
--- trunk/Source/WebCore/animation/CompositeOperationOrAuto.h 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/animation/CompositeOperationOrAuto.h 2022-02-07 15:30:26 UTC (rev 289219)
@@ -41,6 +41,8 @@
case CompositeOperation::Accumulate:
return CompositeOperationOrAuto::Accumulate;
}
+ ASSERT_NOT_REACHED();
+ return CompositeOperationOrAuto::Auto;
}
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp (289218 => 289219)
--- trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp 2022-02-07 15:30:26 UTC (rev 289219)
@@ -58,6 +58,9 @@
case CSSStyleValueType::CSSStyleValue:
return createWrapper<CSSStyleValue>(globalObject, WTFMove(value));
}
+
+ ASSERT_NOT_REACHED();
+ return createWrapper<CSSStyleValue>(globalObject, WTFMove(value));
}
JSValue toJS(JSGlobalObject* lexicalGlobalObject, JSDOMGlobalObject* globalObject, CSSStyleValue& object)
Modified: trunk/Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp (289218 => 289219)
--- trunk/Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/bindings/js/JSCSSTransformComponentCustom.cpp 2022-02-07 15:30:26 UTC (rev 289219)
@@ -63,6 +63,8 @@
case CSSTransformType::Translate:
return createWrapper<CSSTranslate>(globalObject, WTFMove(value));
}
+ ASSERT_NOT_REACHED();
+ return createWrapper<CSSTransformComponent>(globalObject, WTFMove(value));
}
JSValue toJS(JSGlobalObject* lexicalGlobalObject, JSDOMGlobalObject* globalObject, CSSTransformComponent& object)
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (289218 => 289219)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2022-02-07 15:30:26 UTC (rev 289219)
@@ -1388,6 +1388,7 @@
case CompositeOperation::Replace:
return CSSValuePool::singleton().createIdentifierValue(CSSValueReplace);
}
+ RELEASE_ASSERT_NOT_REACHED();
}
static Ref<CSSPrimitiveValue> valueForAnimationPlayState(AnimationPlayState playState)
Modified: trunk/Source/WebCore/css/CSSUnits.cpp (289218 => 289219)
--- trunk/Source/WebCore/css/CSSUnits.cpp 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/css/CSSUnits.cpp 2022-02-07 15:30:26 UTC (rev 289219)
@@ -113,6 +113,8 @@
case CSSUnitType::CustomIdent:
return CSSUnitCategory::Other;
}
+ ASSERT_NOT_REACHED();
+ return CSSUnitCategory::Other;
}
CSSUnitType canonicalUnitTypeForCategory(CSSUnitCategory category)
@@ -135,6 +137,8 @@
case CSSUnitCategory::Other:
return CSSUnitType::CSS_UNKNOWN;
}
+ ASSERT_NOT_REACHED();
+ return CSSUnitType::CSS_UNKNOWN;
}
CSSUnitType canonicalUnitType(CSSUnitType unitType)
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp (289218 => 289219)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2022-02-07 15:27:16 UTC (rev 289218)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2022-02-07 15:30:26 UTC (rev 289219)
@@ -492,6 +492,9 @@
ASSERT_NOT_REACHED();
return { };
}
+
+ ASSERT_NOT_REACHED();
+ return { };
}
std::optional<RTCRtpCapabilities>& LibWebRTCProvider::audioDecodingCapabilities()
@@ -530,6 +533,8 @@
ASSERT_NOT_REACHED();
return { };
}
+ ASSERT_NOT_REACHED();
+ return { };
}
std::optional<RTCRtpCapabilities>& LibWebRTCProvider::audioEncodingCapabilities()
