Title: [107270] trunk/Source/WebCore
- Revision
- 107270
- Author
- [email protected]
- Date
- 2012-02-09 12:04:02 -0800 (Thu, 09 Feb 2012)
Log Message
Unnecessary and incorrect invalidation about composited fixed-position layers
https://bugs.webkit.org/show_bug.cgi?id=75638
When a FrameView scrolls, composited fixed-position layers should
not contribute to the invalidation rect of the root layer.
Reviewed by Simon Fraser.
No new tests. Haven't found a good way to test this programatically.
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107269 => 107270)
--- trunk/Source/WebCore/ChangeLog 2012-02-09 19:56:07 UTC (rev 107269)
+++ trunk/Source/WebCore/ChangeLog 2012-02-09 20:04:02 UTC (rev 107270)
@@ -1,3 +1,18 @@
+2012-02-09 Xianzhu Wang <[email protected]>
+
+ Unnecessary and incorrect invalidation about composited fixed-position layers
+ https://bugs.webkit.org/show_bug.cgi?id=75638
+
+ When a FrameView scrolls, composited fixed-position layers should
+ not contribute to the invalidation rect of the root layer.
+
+ Reviewed by Simon Fraser.
+
+ No new tests. Haven't found a good way to test this programatically.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::scrollContentsFastPath):
+
2012-02-09 Sheriff Bot <[email protected]>
Unreviewed, rolling out r107035.
Modified: trunk/Source/WebCore/page/FrameView.cpp (107269 => 107270)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-02-09 19:56:07 UTC (rev 107269)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-02-09 20:04:02 UTC (rev 107270)
@@ -1463,6 +1463,10 @@
RenderBox* renderBox = *it;
if (renderBox->style()->position() != FixedPosition)
continue;
+#if USE(ACCELERATED_COMPOSITING)
+ if (renderBox->layer()->isComposited())
+ continue;
+#endif
IntRect updateRect = renderBox->layer()->repaintRectIncludingDescendants();
updateRect = contentsToRootView(updateRect);
if (!isCompositedContentLayer && clipsRepaints())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
