Title: [107282] trunk/Source/WebCore
- Revision
- 107282
- Author
- [email protected]
- Date
- 2012-02-09 13:20:49 -0800 (Thu, 09 Feb 2012)
Log Message
[chromium] Correct potential double reserveTextures() in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78258
Reviewed by James Robinson.
This isn't a problem currently, because scrollbar layers don't create
render surfaces. However, if this ever got used for other layers, we
could call reserve on them twice needlessly. It's also just bad form
to have an iterator doing the wrong thing.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::reserveTextures):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107281 => 107282)
--- trunk/Source/WebCore/ChangeLog 2012-02-09 21:07:29 UTC (rev 107281)
+++ trunk/Source/WebCore/ChangeLog 2012-02-09 21:20:49 UTC (rev 107282)
@@ -1,3 +1,18 @@
+2012-02-09 Adrienne Walker <[email protected]>
+
+ [chromium] Correct potential double reserveTextures() in CCLayerTreeHost
+ https://bugs.webkit.org/show_bug.cgi?id=78258
+
+ Reviewed by James Robinson.
+
+ This isn't a problem currently, because scrollbar layers don't create
+ render surfaces. However, if this ever got used for other layers, we
+ could call reserve on them twice needlessly. It's also just bad form
+ to have an iterator doing the wrong thing.
+
+ * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+ (WebCore::CCLayerTreeHost::reserveTextures):
+
2012-02-09 Sheriff Bot <[email protected]>
Unreviewed, rolling out r107261.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (107281 => 107282)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-02-09 21:07:29 UTC (rev 107281)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-02-09 21:20:49 UTC (rev 107282)
@@ -447,7 +447,7 @@
CCLayerIteratorType end = CCLayerIteratorType::end(&m_updateList);
for (CCLayerIteratorType it = CCLayerIteratorType::begin(&m_updateList); it != end; ++it) {
- if (it.representsTargetRenderSurface() || !it->alwaysReserveTextures())
+ if (!it.representsItself() || !it->alwaysReserveTextures())
continue;
it->reserveTextures();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
