Title: [289494] trunk
- Revision
- 289494
- Author
- [email protected]
- Date
- 2022-02-09 11:48:43 -0800 (Wed, 09 Feb 2022)
Log Message
Add TAO check to PerformanceResourceTiming::fetchStart
https://bugs.webkit.org/show_bug.cgi?id=236379
Patch by Alex Christensen <[email protected]> on 2022-02-09
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt:
Source/WebCore:
This matches the spec and was recently changed in Chromium.
<https://chromium-review.googlesource.com/c/chromium/src/+/3448777>
Covered by a newly passing WPT test.
* page/PerformanceResourceTiming.cpp:
(WebCore::fetchStart):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289493 => 289494)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,12 @@
+2022-02-09 Alex Christensen <[email protected]>
+
+ Add TAO check to PerformanceResourceTiming::fetchStart
+ https://bugs.webkit.org/show_bug.cgi?id=236379
+
+ Reviewed by Chris Dumez.
+
+ * web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt:
+
2022-02-09 Chris Dumez <[email protected]>
Worker scripts should always be decoded as UTF-8
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt (289493 => 289494)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,3 @@
-FAIL Verify that cross-origin resources don't implicitly expose their redirect timings assert_less_than: startTime should not expose redirect delays expected a number less than 2000 but got 2033
+PASS Verify that cross-origin resources don't implicitly expose their redirect timings
Modified: trunk/Source/WebCore/ChangeLog (289493 => 289494)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,17 @@
+2022-02-09 Alex Christensen <[email protected]>
+
+ Add TAO check to PerformanceResourceTiming::fetchStart
+ https://bugs.webkit.org/show_bug.cgi?id=236379
+
+ Reviewed by Chris Dumez.
+
+ This matches the spec and was recently changed in Chromium.
+ <https://chromium-review.googlesource.com/c/chromium/src/+/3448777>
+ Covered by a newly passing WPT test.
+
+ * page/PerformanceResourceTiming.cpp:
+ (WebCore::fetchStart):
+
2022-02-09 Gabriel Nava Marino <[email protected]>
Register strings in CSSTokenizer created from preprocessing
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.cpp (289493 => 289494)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2022-02-09 19:48:43 UTC (rev 289494)
@@ -53,7 +53,7 @@
static double fetchStart(MonotonicTime timeOrigin, const ResourceTiming& resourceTiming)
{
- if (auto fetchStart = resourceTiming.networkLoadMetrics().fetchStart)
+ if (auto fetchStart = resourceTiming.networkLoadMetrics().fetchStart; fetchStart && !resourceTiming.networkLoadMetrics().failsTAOCheck)
return networkLoadTimeToDOMHighResTimeStamp(timeOrigin, fetchStart);
// fetchStart is a required property.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
