Title: [289529] trunk/Source/WebCore
- Revision
- 289529
- Author
- [email protected]
- Date
- 2022-02-10 06:14:30 -0800 (Thu, 10 Feb 2022)
Log Message
[GTK] Scrollbars painted incorrectly if theme enables steppers (steppers misplaced on vertical scrollbars, horizontal scrollbars very broken)
https://bugs.webkit.org/show_bug.cgi?id=234871
Reviewed by Carlos Garcia Campos.
Actually use the scrollbar orientation when creating its contents,
instead of always using vertical.
* platform/gtk/RenderThemeScrollbar.cpp:
(WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289528 => 289529)
--- trunk/Source/WebCore/ChangeLog 2022-02-10 13:54:57 UTC (rev 289528)
+++ trunk/Source/WebCore/ChangeLog 2022-02-10 14:14:30 UTC (rev 289529)
@@ -1,3 +1,16 @@
+2022-02-10 Alexander Mikhaylenko <[email protected]>
+
+ [GTK] Scrollbars painted incorrectly if theme enables steppers (steppers misplaced on vertical scrollbars, horizontal scrollbars very broken)
+ https://bugs.webkit.org/show_bug.cgi?id=234871
+
+ Reviewed by Carlos Garcia Campos.
+
+ Actually use the scrollbar orientation when creating its contents,
+ instead of always using vertical.
+
+ * platform/gtk/RenderThemeScrollbar.cpp:
+ (WebCore::RenderThemeScrollbar::RenderThemeScrollbar):
+
2022-02-10 Carlos Garcia Campos <[email protected]>
[GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp (289528 => 289529)
--- trunk/Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp 2022-02-10 13:54:57 UTC (rev 289528)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeScrollbar.cpp 2022-02-10 14:14:30 UTC (rev 289529)
@@ -107,7 +107,7 @@
info.type = RenderThemeGadget::Type::Generic;
info.name = "contents";
info.classList.clear();
- m_contents = makeUnique<RenderThemeBoxGadget>(info, GTK_ORIENTATION_VERTICAL, children, m_scrollbar.get());
+ m_contents = makeUnique<RenderThemeBoxGadget>(info, orientation, children, m_scrollbar.get());
info.name = "slider";
m_slider = RenderThemeGadget::create(info, m_contents->child(m_troughPosition));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes