Title: [289536] trunk
- Revision
- 289536
- Author
- [email protected]
- Date
- 2022-02-10 08:21:47 -0800 (Thu, 10 Feb 2022)
Log Message
Do not expose in WebIDL the parts of the permission API that are not yet supported
https://bugs.webkit.org/show_bug.cgi?id=236301
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/permissions/idlharness.any-expected.txt:
* web-platform-tests/permissions/idlharness.any.worker-expected.txt:
Source/WebCore:
Covered by existing tests.
* Modules/permissions/PermissionStatus.idl:
* Modules/permissions/Permissions.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289535 => 289536)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-10 16:21:47 UTC (rev 289536)
@@ -1,5 +1,15 @@
2022-02-10 Youenn Fablet <[email protected]>
+ Do not expose in WebIDL the parts of the permission API that are not yet supported
+ https://bugs.webkit.org/show_bug.cgi?id=236301
+
+ Reviewed by Chris Dumez.
+
+ * web-platform-tests/permissions/idlharness.any-expected.txt:
+ * web-platform-tests/permissions/idlharness.any.worker-expected.txt:
+
+2022-02-10 Youenn Fablet <[email protected]>
+
Check for feature policy when querying permission state
https://bugs.webkit.org/show_bug.cgi?id=236299
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any-expected.txt (289535 => 289536)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any-expected.txt 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any-expected.txt 2022-02-10 16:21:47 UTC (rev 289536)
@@ -26,11 +26,11 @@
PASS PermissionStatus interface: existence and properties of interface prototype object's "constructor" property
PASS PermissionStatus interface: existence and properties of interface prototype object's @@unscopables property
PASS PermissionStatus interface: attribute state
-PASS PermissionStatus interface: attribute onchange
+FAIL PermissionStatus interface: attribute onchange assert_true: The prototype object must have a property "onchange" expected true got false
PASS PermissionStatus must be primary interface of permissionStatus
PASS Stringification of permissionStatus
PASS PermissionStatus interface: permissionStatus must inherit property "state" with the proper type
-PASS PermissionStatus interface: permissionStatus must inherit property "onchange" with the proper type
+FAIL PermissionStatus interface: permissionStatus must inherit property "onchange" with the proper type assert_inherits: property "onchange" not found in prototype chain
PASS Permissions interface: existence and properties of interface object
PASS Permissions interface object length
PASS Permissions interface object name
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.worker-expected.txt (289535 => 289536)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.worker-expected.txt 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/permissions/idlharness.any.worker-expected.txt 2022-02-10 16:21:47 UTC (rev 289536)
@@ -19,25 +19,25 @@
PASS WorkerNavigator includes NavigatorLanguage: member names are unique
PASS WorkerNavigator includes NavigatorOnLine: member names are unique
PASS WorkerNavigator includes NavigatorConcurrentHardware: member names are unique
-PASS PermissionStatus interface: existence and properties of interface object
-PASS PermissionStatus interface object length
-PASS PermissionStatus interface object name
-PASS PermissionStatus interface: existence and properties of interface prototype object
-PASS PermissionStatus interface: existence and properties of interface prototype object's "constructor" property
-PASS PermissionStatus interface: existence and properties of interface prototype object's @@unscopables property
-PASS PermissionStatus interface: attribute state
-PASS PermissionStatus interface: attribute onchange
+FAIL PermissionStatus interface: existence and properties of interface object assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface object length assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface object name assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface: existence and properties of interface prototype object assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface: attribute state assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
+FAIL PermissionStatus interface: attribute onchange assert_own_property: self does not have own property "PermissionStatus" expected property "PermissionStatus" missing
FAIL PermissionStatus must be primary interface of permissionStatus assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: permissionStatus"
FAIL Stringification of permissionStatus assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: permissionStatus"
FAIL PermissionStatus interface: permissionStatus must inherit property "state" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: permissionStatus"
FAIL PermissionStatus interface: permissionStatus must inherit property "onchange" with the proper type assert_equals: Unexpected exception when evaluating object expected null but got object "ReferenceError: Can't find variable: permissionStatus"
-PASS Permissions interface: existence and properties of interface object
-PASS Permissions interface object length
-PASS Permissions interface object name
-PASS Permissions interface: existence and properties of interface prototype object
-PASS Permissions interface: existence and properties of interface prototype object's "constructor" property
-PASS Permissions interface: existence and properties of interface prototype object's @@unscopables property
-PASS Permissions interface: operation query(object)
+FAIL Permissions interface: existence and properties of interface object assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface object length assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface object name assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface: existence and properties of interface prototype object assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface: existence and properties of interface prototype object's @@unscopables property assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
+FAIL Permissions interface: operation query(object) assert_own_property: self does not have own property "Permissions" expected property "Permissions" missing
FAIL Permissions must be primary interface of navigator.permissions assert_equals: wrong typeof object expected "object" but got "undefined"
FAIL Stringification of navigator.permissions assert_equals: wrong typeof object expected "object" but got "undefined"
FAIL Permissions interface: navigator.permissions must inherit property "query(object)" with the proper type assert_equals: wrong typeof object expected "object" but got "undefined"
Modified: trunk/Source/WebCore/ChangeLog (289535 => 289536)
--- trunk/Source/WebCore/ChangeLog 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/Source/WebCore/ChangeLog 2022-02-10 16:21:47 UTC (rev 289536)
@@ -1,5 +1,17 @@
2022-02-10 Youenn Fablet <[email protected]>
+ Do not expose in WebIDL the parts of the permission API that are not yet supported
+ https://bugs.webkit.org/show_bug.cgi?id=236301
+
+ Reviewed by Chris Dumez.
+
+ Covered by existing tests.
+
+ * Modules/permissions/PermissionStatus.idl:
+ * Modules/permissions/Permissions.idl:
+
+2022-02-10 Youenn Fablet <[email protected]>
+
Check for feature policy when querying permission state
https://bugs.webkit.org/show_bug.cgi?id=236299
Modified: trunk/Source/WebCore/Modules/permissions/PermissionStatus.idl (289535 => 289536)
--- trunk/Source/WebCore/Modules/permissions/PermissionStatus.idl 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/Source/WebCore/Modules/permissions/PermissionStatus.idl 2022-02-10 16:21:47 UTC (rev 289536)
@@ -24,13 +24,14 @@
*/
// https://w3c.github.io/permissions/#permissionstatus
-
+// FIXME: Add worker support: https://bugs.webkit.org/show_bug.cgi?id=236443.
[
ActiveDOMObject,
EnabledBySetting=PermissionsAPIEnabled,
- Exposed=(Window,Worker)
+ Exposed=(Window)
] interface PermissionStatus : EventTarget {
readonly attribute PermissionState state;
readonly attribute PermissionName name;
- attribute EventHandler onchange;
+ // FIXME: Add support for onchange.
+ // attribute EventHandler onchange;
};
Modified: trunk/Source/WebCore/Modules/permissions/Permissions.idl (289535 => 289536)
--- trunk/Source/WebCore/Modules/permissions/Permissions.idl 2022-02-10 15:56:20 UTC (rev 289535)
+++ trunk/Source/WebCore/Modules/permissions/Permissions.idl 2022-02-10 16:21:47 UTC (rev 289536)
@@ -24,11 +24,12 @@
*/
// https://w3c.github.io/permissions/#permissions-interface
+// FIXME: Add worker support: https://bugs.webkit.org/show_bug.cgi?id=236443.
[
EnabledBySetting=PermissionsAPIEnabled,
GenerateIsReachable=ReachableFromNavigator,
- Exposed=(Window,Worker)
+ Exposed=(Window)
] interface Permissions {
Promise<PermissionStatus> query(object permissionDesc);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
