Title: [289538] trunk/Source/WebCore
- Revision
- 289538
- Author
- [email protected]
- Date
- 2022-02-10 08:38:35 -0800 (Thu, 10 Feb 2022)
Log Message
AX: Log more information when the wrapper or the wrapper's backing object is detached
https://bugs.webkit.org/show_bug.cgi?id=236381
Reviewed by Chris Fleizach.
Right now, we don't log any information when we detect a wrapper has
no object, or when it does have an object but it's detached from a
parent.
This patch logs the wrapper address and object in these scenarios, which
will help debug these issues in conjuction with other logs.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper logMissingBackingObject]):
Added.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Use new logMissingBackingObject, and log object if it's detached from a parent.
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
Use new logMissingBackingObject.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289537 => 289538)
--- trunk/Source/WebCore/ChangeLog 2022-02-10 16:36:42 UTC (rev 289537)
+++ trunk/Source/WebCore/ChangeLog 2022-02-10 16:38:35 UTC (rev 289538)
@@ -1,5 +1,27 @@
2022-02-10 Tyler Wilcock <[email protected]>
+ AX: Log more information when the wrapper or the wrapper's backing object is detached
+ https://bugs.webkit.org/show_bug.cgi?id=236381
+
+ Reviewed by Chris Fleizach.
+
+ Right now, we don't log any information when we detect a wrapper has
+ no object, or when it does have an object but it's detached from a
+ parent.
+
+ This patch logs the wrapper address and object in these scenarios, which
+ will help debug these issues in conjuction with other logs.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper logMissingBackingObject]):
+ Added.
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
+ Use new logMissingBackingObject, and log object if it's detached from a parent.
+ (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
+ Use new logMissingBackingObject.
+
+2022-02-10 Tyler Wilcock <[email protected]>
+
AXIsolatedTree::updateChildren and AXIsolatedTree::nodeAncestryChanges results in adding incorrect nodes to the isolated tree
https://bugs.webkit.org/show_bug.cgi?id=236414
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (289537 => 289538)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2022-02-10 16:36:42 UTC (rev 289537)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2022-02-10 16:38:35 UTC (rev 289538)
@@ -1907,6 +1907,13 @@
});
}
+- (void)logMissingBackingObject
+{
+ TextStream stream;
+ stream << "No backingObject for wrapper " << &self << "!";
+ AXLOG(stream.release());
+}
+
// FIXME: split up this function in a better way.
// suggestions: Use a hash table that maps attribute names to function calls,
// or maybe pointers to member functions
@@ -1918,12 +1925,13 @@
auto* backingObject = self.updateObjectBackingStore;
if (!backingObject) {
- AXLOG("No backingObject!!!");
+ [self logMissingBackingObject];
return nil;
}
if (backingObject->isDetachedFromParent()) {
AXLOG("backingObject is detached from parent!!!");
+ AXLOG(backingObject);
return nil;
}
@@ -3104,7 +3112,7 @@
auto* backingObject = self.updateObjectBackingStore;
if (!backingObject) {
- AXLOG("No backingObject!!!");
+ [self logMissingBackingObject];
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
