Title: [289587] trunk
- Revision
- 289587
- Author
- [email protected]
- Date
- 2022-02-10 15:22:23 -0800 (Thu, 10 Feb 2022)
Log Message
[Xcode] Perform a full build when analyzing
https://bugs.webkit.org/show_bug.cgi?id=236421
Reviewed by Alexey Proskuryakov.
`xcodebuild analyze` does just enough work to run the analyzer on each target, and doesn't
appear to run build phases that only impact consumers of the target. In particular, it
doesn't copy framework headers.
Fix by telling xcodebuild to build _and_ analyze at once. AFAICT, this is exactly what
Xcode's Product > Analyze command does.
* Makefile.shared: s/analyze/build analyze
Modified Paths
Diff
Modified: trunk/ChangeLog (289586 => 289587)
--- trunk/ChangeLog 2022-02-10 23:11:24 UTC (rev 289586)
+++ trunk/ChangeLog 2022-02-10 23:22:23 UTC (rev 289587)
@@ -1,3 +1,19 @@
+2022-02-10 Elliott Williams <[email protected]>
+
+ [Xcode] Perform a full build when analyzing
+ https://bugs.webkit.org/show_bug.cgi?id=236421
+
+ Reviewed by Alexey Proskuryakov.
+
+ `xcodebuild analyze` does just enough work to run the analyzer on each target, and doesn't
+ appear to run build phases that only impact consumers of the target. In particular, it
+ doesn't copy framework headers.
+
+ Fix by telling xcodebuild to build _and_ analyze at once. AFAICT, this is exactly what
+ Xcode's Product > Analyze command does.
+
+ * Makefile.shared: s/analyze/build analyze
+
2022-02-10 Alejandro G. Castro <[email protected]>
[GTK][WPE] Improve device detection in the GbmDevice
Modified: trunk/Makefile.shared (289586 => 289587)
--- trunk/Makefile.shared 2022-02-10 23:11:24 UTC (rev 289586)
+++ trunk/Makefile.shared 2022-02-10 23:22:23 UTC (rev 289587)
@@ -138,7 +138,7 @@
analyze:
@$(call set_webkit_configuration,--debug)
- @$(call invoke_xcode,$(PATH_TO_SCAN_BUILD),analyze,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
+ @$(call invoke_xcode,$(PATH_TO_SCAN_BUILD),build analyze,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
clean:
ifndef XCODE_TARGET
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
