Title: [289600] trunk/Source/WebCore
Revision
289600
Author
[email protected]
Date
2022-02-10 19:58:02 -0800 (Thu, 10 Feb 2022)

Log Message

[LFC][IFC] Non-content runs (e.g. inline box start/end) do not need "within the line" flip
https://bugs.webkit.org/show_bug.cgi?id=236426

Reviewed by Antti Koivisto.

This is the same what we already do for the bidi case.

* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (289599 => 289600)


--- trunk/Source/WebCore/ChangeLog	2022-02-11 02:27:02 UTC (rev 289599)
+++ trunk/Source/WebCore/ChangeLog	2022-02-11 03:58:02 UTC (rev 289600)
@@ -1,3 +1,15 @@
+2022-02-10  Alan Bujtas  <[email protected]>
+
+        [LFC][IFC] Non-content runs (e.g. inline box start/end) do not need "within the line" flip
+        https://bugs.webkit.org/show_bug.cgi?id=236426
+
+        Reviewed by Antti Koivisto.
+
+        This is the same what we already do for the bidi case.
+
+        * layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
+        (WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
+
 2022-02-10  Nikolaos Mouchtaris  <[email protected]>
 
         Web animations- Composite operation accumulation support for transform properties

Modified: trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp (289599 => 289600)


--- trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp	2022-02-11 02:27:02 UTC (rev 289599)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp	2022-02-11 03:58:02 UTC (rev 289600)
@@ -330,7 +330,9 @@
         auto& layoutBox = lineRun.layoutBox();
 
         auto visualRectRelativeToRoot = [&](auto logicalRect) {
-            auto visualRect = flipLogicalRectToVisualForWritingModeWithinLine(logicalRect, lineBox.logicalRect(), writingMode);
+            auto isContentRun = !lineRun.isInlineBoxStart() && !lineRun.isInlineBoxEnd() && !lineRun.isLineSpanningInlineBoxStart();
+            auto visualRect = isContentRun ? flipLogicalRectToVisualForWritingModeWithinLine(logicalRect, lineBox.logicalRect(), writingMode)
+                : flipLogicalRectToVisualForWritingMode(logicalRect, writingMode);
             visualRect.moveBy(contentStartInVisualOrder);
             return visualRect;
         };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to