Title: [289602] trunk/Source/WTF
- Revision
- 289602
- Author
- [email protected]
- Date
- 2022-02-10 21:17:40 -0800 (Thu, 10 Feb 2022)
Log Message
[WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit
<https://webkit.org/b/236459>
<rdar://problem/88772313>
Reviewed by Darin Adler.
* wtf/IteratorAdaptors.h:
(WTF::makeTransformIterator):
* wtf/WeakHashMap.h:
(WTF::WeakHashMap::set):
- Replace WTFMove() with std::forward<>().
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (289601 => 289602)
--- trunk/Source/WTF/ChangeLog 2022-02-11 03:58:39 UTC (rev 289601)
+++ trunk/Source/WTF/ChangeLog 2022-02-11 05:17:40 UTC (rev 289602)
@@ -1,3 +1,17 @@
+2022-02-10 David Kilzer <[email protected]>
+
+ [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings from WebCore/WebKit
+ <https://webkit.org/b/236459>
+ <rdar://problem/88772313>
+
+ Reviewed by Darin Adler.
+
+ * wtf/IteratorAdaptors.h:
+ (WTF::makeTransformIterator):
+ * wtf/WeakHashMap.h:
+ (WTF::WeakHashMap::set):
+ - Replace WTFMove() with std::forward<>().
+
2022-02-10 Commit Queue <[email protected]>
Unreviewed, reverting r289583 and r289591.
Modified: trunk/Source/WTF/wtf/IteratorAdaptors.h (289601 => 289602)
--- trunk/Source/WTF/wtf/IteratorAdaptors.h 2022-02-11 03:58:39 UTC (rev 289601)
+++ trunk/Source/WTF/wtf/IteratorAdaptors.h 2022-02-11 05:17:40 UTC (rev 289602)
@@ -106,7 +106,7 @@
template<typename Transform, typename Iterator>
inline TransformIterator<Transform, Iterator> makeTransformIterator(Transform&& transform, Iterator&& iter)
{
- return TransformIterator<Transform, Iterator>(WTFMove(transform), WTFMove(iter));
+ return TransformIterator<Transform, Iterator>(std::forward<Transform>(transform), std::forward<Iterator>(iter));
}
} // namespace WTF
Modified: trunk/Source/WTF/wtf/WeakHashMap.h (289601 => 289602)
--- trunk/Source/WTF/wtf/WeakHashMap.h 2022-02-11 03:58:39 UTC (rev 289601)
+++ trunk/Source/WTF/wtf/WeakHashMap.h 2022-02-11 05:17:40 UTC (rev 289602)
@@ -221,7 +221,7 @@
void set(const T& key, V&& value)
{
amortizedCleanupIfNeeded();
- m_map.set(makeKeyImpl(key), WTFMove(value));
+ m_map.set(makeKeyImpl(key), std::forward<V>(value));
}
iterator find(const KeyType& key)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
