Diff
Modified: trunk/Tools/ChangeLog (107301 => 107302)
--- trunk/Tools/ChangeLog 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/ChangeLog 2012-02-10 00:09:31 UTC (rev 107302)
@@ -1,5 +1,46 @@
2012-02-09 Eric Seidel <[email protected]>
+ Remove more uses of "os" from our webkitpy code
+ https://bugs.webkit.org/show_bug.cgi?id=78292
+
+ Reviewed by Adam Barth.
+
+ * Scripts/webkitpy/common/checkout/checkout_mock.py:
+ (MockCheckout.__init__):
+ (MockCheckout.is_path_to_changelog):
+ * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+ * Scripts/webkitpy/common/system/filesystem_mock.py:
+ (MockFileSystem._split):
+ * Scripts/webkitpy/common/system/zipfileset_unittest.py:
+ * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+ * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+ * Scripts/webkitpy/layout_tests/port/webkit.py:
+ * Scripts/webkitpy/tool/bot/queueengine.py:
+ * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
+ * Scripts/webkitpy/tool/commands/download.py:
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ * Scripts/webkitpy/tool/commands/rebaselineserver.py:
+ * Scripts/webkitpy/tool/commands/sheriffbot.py:
+ * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
+ * Scripts/webkitpy/tool/commands/upload.py:
+ (CreateBug.prompt_for_bug_title_and_comment):
+ * Scripts/webkitpy/tool/servers/reflectionhandler.py:
+ * Scripts/webkitpy/tool/steps/attachtobug.py:
+ (AttachToBug.run):
+ * Scripts/webkitpy/tool/steps/checkstyle.py:
+ * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
+ * Scripts/webkitpy/tool/steps/commit_unittest.py:
+ * Scripts/webkitpy/tool/steps/editchangelog.py:
+ * Scripts/webkitpy/tool/steps/preparechangelog.py:
+ * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
+ (PrepareChangeLogTest.test_ensure_bug_url):
+ * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
+ * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
+ * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
+ * Scripts/webkitpy/tool/steps/validatereviewer.py:
+
+2012-02-09 Eric Seidel <[email protected]>
+
Remove the cr-mac-ews (it's long been dead)
https://bugs.webkit.org/show_bug.cgi?id=78267
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_mock.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,14 +26,13 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from .deps_mock import MockDEPS
from .commitinfo import CommitInfo
# FIXME: These imports are wrong, we should use a shared MockCommittersList.
from webkitpy.common.config.committers import CommitterList
from webkitpy.common.net.bugzilla.bugzilla_mock import _mock_reviewers
+from webkitpy.common.system.filesystem_mock import MockFileSystem
class MockCommitMessage(object):
@@ -42,6 +41,10 @@
class MockCheckout(object):
+ def __init__(self):
+ # FIXME: It's unclear if a MockCheckout is very useful. A normal Checkout
+ # with a MockSCM/MockFileSystem/MockExecutive is probably better.
+ self._filesystem = MockFileSystem()
# FIXME: This should move onto the Host object, and we should use a MockCommitterList for tests.
_committer_list = CommitterList()
@@ -64,8 +67,7 @@
})
def is_path_to_changelog(self, path):
- # FIXME: This should self._filesystem.basename.
- return os.path.basename(path) == "ChangeLog"
+ return self._filesystem.basename(path) == "ChangeLog"
def bug_id_for_revision(self, svn_revision):
return 12345
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -31,7 +31,6 @@
# WebKit's Python module for interacting with Bugzilla
import mimetypes
-import os.path
import re
import StringIO
import urllib
Modified: trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/common/system/filesystem_mock.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -71,7 +71,11 @@
raise IOError(errno.ENOENT, path, os.strerror(errno.ENOENT))
def _split(self, path):
- return path.rsplit(self.sep, 1)
+ # This is not quite a full implementation of os.path.split
+ # http://docs.python.org/library/os.path.html#os.path.split
+ if self.sep in path:
+ return path.rsplit(self.sep, 1)
+ return ('', path)
def abspath(self, path):
if os.path.isabs(path):
Modified: trunk/Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/common/system/zipfileset_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -21,7 +21,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
import shutil
import tempfile
import unittest
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -28,7 +28,6 @@
import logging
-import os
from webkitpy.common.system.crashlogs import CrashLogs
from webkitpy.layout_tests.models import test_failures
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -28,7 +28,6 @@
import json
import logging
-import os
import subprocess
import sys
import time
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -35,7 +35,6 @@
import itertools
import logging
import operator
-import os
import re
import sys
import time
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/queueengine.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -27,9 +27,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
import sys
-import time
import traceback
from datetime import datetime, timedelta
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,7 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
import unittest
from webkitpy.common.net.buildbot import Builder
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -27,8 +27,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.tool import steps
from webkitpy.common.checkout.changelog import ChangeLog
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.thirdparty.mock import Mock
from webkitpy.common.system.outputcapture import OutputCapture
from webkitpy.tool.bot.queueengine import QueueEngine
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -30,9 +30,6 @@
results directory), provides comparisons of expected and actual results (both
images and text) and allows one-click rebaselining of tests."""
-import os
-import os.path
-
from webkitpy.common import system
from webkitpy.common.net.resultsjsonparser import for_each_test, JSONTestResult
from webkitpy.layout_tests.layout_package import json_results_generator
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.system.deprecated_logging import log
from webkitpy.tool.bot.sheriff import Sheriff
from webkitpy.tool.bot.sheriffircbot import SheriffIRCBot
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,11 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.tool.commands.queuestest import QueuesTest
-from webkitpy.tool.commands.sheriffbot import SheriffBot
-from webkitpy.tool.mocktool import *
class SheriffBotTest(QueuesTest):
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/commands/upload.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/upload.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -482,6 +482,7 @@
def prompt_for_bug_title_and_comment(self):
bug_title = User.prompt("Bug title: ")
+ # FIXME: User should provide a function for doing this multi-line prompt.
print "Bug comment (hit ^D on blank line to end):"
lines = sys.stdin.readlines()
try:
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -34,7 +34,6 @@
import fnmatch
import json
import mimetypes
-import os
import os.path
import shutil
import threading
@@ -43,6 +42,7 @@
import wsgiref.handlers
import BaseHTTPServer
+
class ReflectionHandler(BaseHTTPServer.BaseHTTPRequestHandler):
# Subclasses should override.
STATIC_FILE_NAMES = None
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/attachtobug.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/attachtobug.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/attachtobug.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.tool.steps.abstractstep import AbstractStep
from webkitpy.tool.steps.options import Options
@@ -43,7 +41,7 @@
def run(self, state):
filepath = state["filepath"]
bug_id = state["bug_id"]
- description = self._options.description or filepath.split(os.sep)[-1]
+ description = self._options.description or self._tool.filesystem.basename(filepath)
comment_text = self._options.comment
# add_attachment_to_bug fills in the filename from the file path.
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/checkstyle.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/checkstyle.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/checkstyle.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.system.executive import ScriptError
from webkitpy.tool.steps.abstractstep import AbstractStep
from webkitpy.tool.steps.options import Options
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.tool.steps.abstractstep import AbstractStep
from webkitpy.tool.steps.options import Options
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,7 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
import unittest
from webkitpy.common.system.outputcapture import OutputCapture
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/editchangelog.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/editchangelog.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/editchangelog.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.tool.steps.abstractstep import AbstractStep
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.checkout.changelog import ChangeLog
from webkitpy.common.system.executive import ScriptError
from webkitpy.tool.steps.abstractstep import AbstractStep
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -39,6 +39,7 @@
class PrepareChangeLogTest(changelog_unittest.ChangeLogTest):
def test_ensure_bug_url(self):
+ # FIXME: This should use a MockFileSystem instead of a real FileSystem.
capture = OutputCapture()
step = PrepareChangeLog(MockTool(), MockOptions())
changelog_contents = u"%s\n%s" % (self._new_entry_boilerplate, self._example_changelog)
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.checkout.changelog import ChangeLog
from webkitpy.tool.steps.abstractstep import AbstractStep
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.checkout.changelog import ChangeLog
from webkitpy.common.config import urls
from webkitpy.tool.grammar import join_with_separators
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,8 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-
from webkitpy.common.checkout.changelog import ChangeLog
from webkitpy.tool.grammar import pluralize
from webkitpy.tool.steps.abstractstep import AbstractStep
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py (107301 => 107302)
--- trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py 2012-02-10 00:05:10 UTC (rev 107301)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py 2012-02-10 00:09:31 UTC (rev 107302)
@@ -26,9 +26,6 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-import os
-import re
-
from webkitpy.common.checkout.changelog import ChangeLog
from webkitpy.tool.steps.abstractstep import AbstractStep
from webkitpy.tool.steps.options import Options
