Title: [289689] trunk/Source/_javascript_Core
- Revision
- 289689
- Author
- [email protected]
- Date
- 2022-02-11 18:29:56 -0800 (Fri, 11 Feb 2022)
Log Message
Allow structureHeapAddressSize to be set during build
https://bugs.webkit.org/show_bug.cgi?id=236527
Reviewed by Yusuke Suzuki.
Add `STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB` as a way to set the size of
structureHeapAddressSize at build time. Set a default for the PlayStation port.
* PlatformPlayStation.cmake:
* runtime/JSCConfig.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (289688 => 289689)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-12 02:04:36 UTC (rev 289688)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-12 02:29:56 UTC (rev 289689)
@@ -1,3 +1,16 @@
+2022-02-11 Don Olmstead <[email protected]>
+
+ Allow structureHeapAddressSize to be set during build
+ https://bugs.webkit.org/show_bug.cgi?id=236527
+
+ Reviewed by Yusuke Suzuki.
+
+ Add `STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB` as a way to set the size of
+ structureHeapAddressSize at build time. Set a default for the PlayStation port.
+
+ * PlatformPlayStation.cmake:
+ * runtime/JSCConfig.h:
+
2022-02-10 Keith Miller <[email protected]>
tryReserveUncommittedAligned should explicitly take the alignment requested
Modified: trunk/Source/_javascript_Core/PlatformPlayStation.cmake (289688 => 289689)
--- trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-02-12 02:04:36 UTC (rev 289688)
+++ trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-02-12 02:29:56 UTC (rev 289689)
@@ -34,5 +34,10 @@
)
endif ()
+# This overrides the default value of 1GB for the structure heap address size
+list(APPEND _javascript_Core_DEFINITIONS
+ STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB=128
+)
+
# This overrides the default x64 value of 1GB for the memory pool size
add_definitions(-DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=64)
Modified: trunk/Source/_javascript_Core/runtime/JSCConfig.h (289688 => 289689)
--- trunk/Source/_javascript_Core/runtime/JSCConfig.h 2022-02-12 02:04:36 UTC (rev 289688)
+++ trunk/Source/_javascript_Core/runtime/JSCConfig.h 2022-02-12 02:29:56 UTC (rev 289689)
@@ -41,7 +41,9 @@
using JITWriteSeparateHeapsFunction = void (*)(off_t, const void*, size_t);
#endif
-#if PLATFORM(IOS_FAMILY) && CPU(ARM64) && !CPU(ARM64E)
+#if defined(STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB) && STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB > 0
+constexpr uintptr_t structureHeapAddressSize = STRUCTURE_HEAP_ADDRESS_SIZE_IN_MB * MB;
+#elif PLATFORM(IOS_FAMILY) && CPU(ARM64) && !CPU(ARM64E)
constexpr uintptr_t structureHeapAddressSize = 512 * MB;
#else
constexpr uintptr_t structureHeapAddressSize = 1 * GB;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
