Title: [289695] trunk/Source/_javascript_Core
- Revision
- 289695
- Author
- [email protected]
- Date
- 2022-02-12 07:48:00 -0800 (Sat, 12 Feb 2022)
Log Message
[CMake] REGRESSION(r289611): Debug builds fail linking binaries with ld.lld
https://bugs.webkit.org/show_bug.cgi?id=236506
Reviewed by Yusuke Suzuki.
* jit/ThunkGenerators.cpp: Use .previous in inline assembler for thunks in order to ensure
that mixed emission of assembler code and variable definitions correctly puts each of them
in their rightful sections in the output object code.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (289694 => 289695)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-12 15:42:10 UTC (rev 289694)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-12 15:48:00 UTC (rev 289695)
@@ -1,3 +1,14 @@
+2022-02-12 Adrian Perez de Castro <[email protected]>
+
+ [CMake] REGRESSION(r289611): Debug builds fail linking binaries with ld.lld
+ https://bugs.webkit.org/show_bug.cgi?id=236506
+
+ Reviewed by Yusuke Suzuki.
+
+ * jit/ThunkGenerators.cpp: Use .previous in inline assembler for thunks in order to ensure
+ that mixed emission of assembler code and variable definitions correctly puts each of them
+ in their rightful sections in the output object code.
+
2022-02-11 Don Olmstead <[email protected]>
Allow structureHeapAddressSize to be set during build
Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (289694 => 289695)
--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2022-02-12 15:42:10 UTC (rev 289694)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2022-02-12 15:48:00 UTC (rev 289695)
@@ -902,6 +902,7 @@
"call " GLOBAL_REFERENCE(function) "\n" \
"popq %rcx\n" \
"ret\n" \
+ ".previous\n" \
);\
extern "C" { \
MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
@@ -927,6 +928,7 @@
"addl $20, %esp\n" \
"popl %ebx\n" \
"ret\n" \
+ ".previous\n" \
);\
extern "C" { \
MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
@@ -948,6 +950,7 @@
"movsd (%esp), %xmm0 \n" \
"addl $20, %esp\n" \
"ret\n" \
+ ".previous\n" \
);\
extern "C" { \
MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
@@ -972,6 +975,7 @@
"vmov d0, r0, r1\n" \
"pop {lr}\n" \
"bx lr\n" \
+ ".previous\n" \
); \
extern "C" { \
MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
@@ -989,7 +993,7 @@
HIDE_SYMBOL(function##Thunk) "\n" \
SYMBOL_STRING(function##Thunk) ":" "\n" \
"b " GLOBAL_REFERENCE(function) "\n" \
- ".previous" \
+ ".previous\n" \
); \
extern "C" { \
MathThunkCallingConvention function##Thunk(MathThunkCallingConvention); \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
