Title: [289717] trunk/Source/_javascript_Core
Revision
289717
Author
[email protected]
Date
2022-02-13 12:22:24 -0800 (Sun, 13 Feb 2022)

Log Message

Make StructureMemoryManager alignment assert a RELEASE_ASSERT
https://bugs.webkit.org/show_bug.cgi?id=236567

Reviewed by Saam Barati.

Also, check the structure base pointer is non-zero.

* heap/StructureAlignedMemoryAllocator.cpp:
(JSC::StructureMemoryManager::StructureMemoryManager):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (289716 => 289717)


--- trunk/Source/_javascript_Core/ChangeLog	2022-02-13 18:06:27 UTC (rev 289716)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-02-13 20:22:24 UTC (rev 289717)
@@ -1,3 +1,15 @@
+2022-02-13  Keith Miller  <[email protected]>
+
+        Make StructureMemoryManager alignment assert a RELEASE_ASSERT
+        https://bugs.webkit.org/show_bug.cgi?id=236567
+
+        Reviewed by Saam Barati.
+
+        Also, check the structure base pointer is non-zero.
+
+        * heap/StructureAlignedMemoryAllocator.cpp:
+        (JSC::StructureMemoryManager::StructureMemoryManager):
+
 2022-02-12  Adrian Perez de Castro  <[email protected]>
 
         [CMake] REGRESSION(r289611): Debug builds fail linking binaries with ld.lld

Modified: trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp (289716 => 289717)


--- trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp	2022-02-13 18:06:27 UTC (rev 289716)
+++ trunk/Source/_javascript_Core/heap/StructureAlignedMemoryAllocator.cpp	2022-02-13 20:22:24 UTC (rev 289717)
@@ -82,7 +82,7 @@
             m_mappedHeapSize /= 2;
         }
 
-        ASSERT((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap);
+        RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap));
     }
 
     void* tryMallocStructureBlock()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to