Title: [289719] trunk/LayoutTests
Revision
289719
Author
[email protected]
Date
2022-02-13 12:48:52 -0800 (Sun, 13 Feb 2022)

Log Message

Fix for accessibility/image-map1.html in isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=236565
<rdar://problem/88874467>

Reviewed by Darin Adler.

Don't use focus manipulation just to retrieve an accessible element,
instead use accessibilityElementById. Updated the outdated code in this
test.

* accessibility/image-map1-expected.txt:
* accessibility/image-map1.html:
* platform/glib/accessibility/image-map1-expected.txt:
* platform/win/accessibility/image-map1-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (289718 => 289719)


--- trunk/LayoutTests/ChangeLog	2022-02-13 20:26:12 UTC (rev 289718)
+++ trunk/LayoutTests/ChangeLog	2022-02-13 20:48:52 UTC (rev 289719)
@@ -1,3 +1,20 @@
+2022-02-13  Andres Gonzalez  <[email protected]>
+
+        Fix for accessibility/image-map1.html in isolated tree mode.
+        https://bugs.webkit.org/show_bug.cgi?id=236565
+        <rdar://problem/88874467>
+
+        Reviewed by Darin Adler.
+
+        Don't use focus manipulation just to retrieve an accessible element,
+        instead use accessibilityElementById. Updated the outdated code in this
+        test.
+
+        * accessibility/image-map1-expected.txt:
+        * accessibility/image-map1.html:
+        * platform/glib/accessibility/image-map1-expected.txt:
+        * platform/win/accessibility/image-map1-expected.txt:
+
 2022-02-13  Alan Bujtas  <[email protected]>
 
         [LFC][IFC] Take writing direction into account when setting up the root geometry

Modified: trunk/LayoutTests/accessibility/image-map1-expected.txt (289718 => 289719)


--- trunk/LayoutTests/accessibility/image-map1-expected.txt	2022-02-13 20:26:12 UTC (rev 289718)
+++ trunk/LayoutTests/accessibility/image-map1-expected.txt	2022-02-13 20:48:52 UTC (rev 289719)
@@ -1,21 +1,21 @@
-
 This tests that you can reach the links within an image map.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Link1 role: AXRole: AXLink
-Link1 title: AXTitle:
-Link1 description: AXDescription: Link1
+Link1 AXRole: AXLink
+Link1 AXTitle:
+Link1 AXDescription: Link1
 
-Link2 role: AXRole: AXLink
-Link2 title: AXTitle:
-Link2 description: AXDescription: Link2
+Link2 AXRole: AXLink
+Link2 AXTitle:
+Link2 AXDescription: Link2
 
-Link3 role: AXRole: AXLink
-Link3 title: AXTitle:
-Link3 description: AXDescription: Link3
+Link3 AXRole: AXLink
+Link3 AXTitle:
+Link3 AXDescription: Link3
 
+
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/accessibility/image-map1.html (289718 => 289719)


--- trunk/LayoutTests/accessibility/image-map1.html	2022-02-13 20:26:12 UTC (rev 289718)
+++ trunk/LayoutTests/accessibility/image-map1.html	2022-02-13 20:48:52 UTC (rev 289719)
@@ -1,42 +1,34 @@
 <html>
 <head>
-<script src=""
+<script src=""
 </head>
-<script>
-    if (window.testRunner)
-        testRunner.dumpAsText();
-</script>
-<body id="body">
-    
-    <!-- Test image map -->
+<body>
+
+<div id="content" role="group">
     <map id="apple" name="imagemap1">
-      <area shape="rect" coords="10,10,133,72" href="" title="Link1" />
-      <area shape="rect" coords="12,74,134,88" href="" title="Link2" />
-      <area shape="rect" coords="11,91,133,105" href="" title="Link3" />
-      <area shape="default" nohref="nohref" alt="" />
+        <area shape="rect" coords="10,10,133,72" href="" title="Link1" />
+        <area shape="rect" coords="12,74,134,88" href="" title="Link2" />
+        <area shape="rect" coords="11,91,133,105" href="" title="Link3" />
+        <area shape="default" nohref="nohref" alt="" />
     </map>
 
-    <img src=""  border="0" align="left" usemap="" vspace="1">
+    <img src="" border="0" align="left" usemap="" vspace="1">
+</div>
 
-<p id="description"></p>
-<div id="console"></div>
-     
 <script>
-        description("This tests that you can reach the links within an image map.");
+    description("This tests that you can reach the links within an image map.");
 
-        if (window.accessibilityController) {
-            document.getElementById("body").focus();
-
-            var body = accessibilityController.focusedElement;
-            for (var k = 0; k < 3; k++) {
-                var link = body.childAtIndex(k);
-                debug("Link" + (k + 1) + " role: " + link.role);
-                debug("Link" + (k + 1) + " title: " + link.title);
-                debug("Link" + (k + 1) + " description: " + link.description + "\n");
-            }
-         }
+    if (window.accessibilityController) {
+        let content = accessibilityController.accessibleElementById("content");
+        let output = "";
+        for (let k = 0; k < 3; ++k) {
+            let link = content.childAtIndex(k);
+            output += `Link${k + 1} ${link.role}\n`;
+            output += `Link${k + 1} ${link.title}\n`;
+            output += `Link${k + 1} ${link.description}\n\n`;
+        }
+        debug(output);
+    }
 </script>
-
-<script src=""
 </body>
 </html>

Modified: trunk/LayoutTests/platform/glib/accessibility/image-map1-expected.txt (289718 => 289719)


--- trunk/LayoutTests/platform/glib/accessibility/image-map1-expected.txt	2022-02-13 20:26:12 UTC (rev 289718)
+++ trunk/LayoutTests/platform/glib/accessibility/image-map1-expected.txt	2022-02-13 20:48:52 UTC (rev 289719)
@@ -1,21 +1,21 @@
-
 This tests that you can reach the links within an image map.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Link1 role: AXRole: AXLink
-Link1 title: AXTitle: Link1
-Link1 description: AXDescription:
+Link1 AXRole: AXLink
+Link1 AXTitle: Link1
+Link1 AXDescription:
 
-Link2 role: AXRole: AXLink
-Link2 title: AXTitle: Link2
-Link2 description: AXDescription:
+Link2 AXRole: AXLink
+Link2 AXTitle: Link2
+Link2 AXDescription:
 
-Link3 role: AXRole: AXLink
-Link3 title: AXTitle: Link3
-Link3 description: AXDescription:
+Link3 AXRole: AXLink
+Link3 AXTitle: Link3
+Link3 AXDescription:
 
+
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/platform/win/accessibility/image-map1-expected.txt (289718 => 289719)


--- trunk/LayoutTests/platform/win/accessibility/image-map1-expected.txt	2022-02-13 20:26:12 UTC (rev 289718)
+++ trunk/LayoutTests/platform/win/accessibility/image-map1-expected.txt	2022-02-13 20:48:52 UTC (rev 289719)
@@ -1,21 +1,21 @@
-
 This tests that you can reach the links within an image map.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Link1 role: AXRole: AXLink
-Link1 title: AXTitle:
-Link1 description: AXDescription:
+Link1 AXRole: AXLink
+Link1 AXTitle:
+Link1 AXDescription:
 
-Link2 role: AXRole: AXLink
-Link2 title: AXTitle:
-Link2 description: AXDescription:
+Link2 AXRole: AXLink
+Link2 AXTitle:
+Link2 AXDescription:
 
-Link3 role: AXRole: AXLink
-Link3 title: AXTitle:
-Link3 description: AXDescription:
+Link3 AXRole: AXLink
+Link3 AXTitle:
+Link3 AXDescription:
 
+
 PASS successfullyParsed is true
 
 TEST COMPLETE
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to