[webkit-changes] [289756] trunk/Tools

Mon, 14 Feb 2022 12:58:13 -0800

Title: [289756] trunk/Tools
Revision
289756
Author
[email protected]
Date
2022-02-14 12:57:22 -0800 (Mon, 14 Feb 2022)

Log Message

[EWS] Rebase PRs on tip of branch (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=236389
<rdar://problem/88705147>

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(CleanGitRepo.run): Squash `git rebase --abort` errors.
* CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/247229@main

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (289755 => 289756)


--- trunk/Tools/CISupport/ews-build/steps.py	2022-02-14 20:49:48 UTC (rev 289755)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-02-14 20:57:22 UTC (rev 289756)
@@ -3903,7 +3903,7 @@
         branch = self.getProperty('basename', self.default_branch)
         self.commands = []
         for command in [
-            ['git', 'rebase', '--abort'],
+            ['/bin/sh', '-c', 'git rebase --abort & true'],
             ['git', 'clean', '-f', '-d'],  # Remove any left-over layout test results, added files, etc.
             ['git', 'fetch', self.git_remote],  # Avoid updating the working copy to a stale revision.
             ['git', 'checkout', '{}/{}'.format(self.git_remote, branch), '-f'],  # Checkout branch from specific remote

Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (289755 => 289756)


--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-14 20:49:48 UTC (rev 289755)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2022-02-14 20:57:22 UTC (rev 289756)
@@ -4567,7 +4567,7 @@
         self.setProperty('buildername', 'Style-EWS')
 
         self.expectRemoteCommands(
-            ExpectShell(command=['git', 'rebase', '--abort'], workdir='wkdir', timeout=300, logEnviron=False) + 0
+            ExpectShell(command=['/bin/sh', '-c', 'git rebase --abort & true'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
             ExpectShell(command=['git', 'clean', '-f', '-d'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
@@ -4588,7 +4588,7 @@
         self.setProperty('buildername', 'Commit-Queue')
 
         self.expectRemoteCommands(
-            ExpectShell(command=['git', 'rebase', '--abort'], workdir='wkdir', timeout=300, logEnviron=False) + 0
+            ExpectShell(command=['/bin/sh', '-c', 'git rebase --abort & true'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
             ExpectShell(command=['git', 'clean', '-f', '-d'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
@@ -4609,7 +4609,7 @@
         self.setProperty('buildername', 'Commit-Queue')
 
         self.expectRemoteCommands(
-            ExpectShell(command=['git', 'rebase', '--abort'], workdir='wkdir', timeout=300, logEnviron=False) + 0
+            ExpectShell(command=['/bin/sh', '-c', 'git rebase --abort & true'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
             ExpectShell(command=['git', 'clean', '-f', '-d'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
@@ -4631,7 +4631,7 @@
         self.setProperty('basename', 'safari-612-branch')
 
         self.expectRemoteCommands(
-            ExpectShell(command=['git', 'rebase', '--abort'], workdir='wkdir', timeout=300, logEnviron=False) + 0
+            ExpectShell(command=['/bin/sh', '-c', 'git rebase --abort & true'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),
             ExpectShell(command=['git', 'clean', '-f', '-d'], workdir='wkdir', timeout=300, logEnviron=False) + 0
             + ExpectShell.log('stdio', stdout=''),

Modified: trunk/Tools/ChangeLog (289755 => 289756)


--- trunk/Tools/ChangeLog	2022-02-14 20:49:48 UTC (rev 289755)
+++ trunk/Tools/ChangeLog	2022-02-14 20:57:22 UTC (rev 289756)
@@ -1,3 +1,15 @@
+2022-02-14  Jonathan Bedard  <[email protected]>
+
+        [EWS] Rebase PRs on tip of branch (Follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=236389
+        <rdar://problem/88705147>
+
+        Reviewed by Aakash Jain.
+
+        * CISupport/ews-build/steps.py:
+        (CleanGitRepo.run): Squash `git rebase --abort` errors.
+        * CISupport/ews-build/steps_unittest.py:
+
 2022-02-14  Fujii Hironori  <[email protected]>
 
         run-jsc-stress-tests reports "in `<module:URI>': uninitialized class variable @@schemes in URI (NameError)" with Ruby 3.1

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to