Title: [289779] trunk/Source/_javascript_Core
- Revision
- 289779
- Author
- [email protected]
- Date
- 2022-02-14 16:09:10 -0800 (Mon, 14 Feb 2022)
Log Message
[CMake] Remove uses of add_definitions in _javascript_Core build
https://bugs.webkit.org/show_bug.cgi?id=236605
Reviewed by Michael Catanzaro.
Use target specific definitions when building _javascript_Core. In the current cases the
definitions don't need to propagate to targets using _javascript_Core so
_javascript_Core_PRIVATE_DEFINITIONS is used.
* PlatformGTK.cmake:
* PlatformPlayStation.cmake:
* PlatformWPE.cmake:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (289778 => 289779)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-15 00:05:24 UTC (rev 289778)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-15 00:09:10 UTC (rev 289779)
@@ -1,3 +1,18 @@
+2022-02-14 Don Olmstead <[email protected]>
+
+ [CMake] Remove uses of add_definitions in _javascript_Core build
+ https://bugs.webkit.org/show_bug.cgi?id=236605
+
+ Reviewed by Michael Catanzaro.
+
+ Use target specific definitions when building _javascript_Core. In the current cases the
+ definitions don't need to propagate to targets using _javascript_Core so
+ _javascript_Core_PRIVATE_DEFINITIONS is used.
+
+ * PlatformGTK.cmake:
+ * PlatformPlayStation.cmake:
+ * PlatformWPE.cmake:
+
2022-02-14 Zan Dobersek <[email protected]>
CallLinkInfo::emitFastPathImpl() should avoid external scratch register use on RISCV64
Modified: trunk/Source/_javascript_Core/PlatformGTK.cmake (289778 => 289779)
--- trunk/Source/_javascript_Core/PlatformGTK.cmake 2022-02-15 00:05:24 UTC (rev 289778)
+++ trunk/Source/_javascript_Core/PlatformGTK.cmake 2022-02-15 00:09:10 UTC (rev 289779)
@@ -36,7 +36,7 @@
)
endif ()
-add_definitions(-DJSC_COMPILATION)
+list(APPEND _javascript_Core_PRIVATE_DEFINITIONS JSC_COMPILATION)
list(APPEND _javascript_Core_LIBRARIES
${GLIB_LIBRARIES}
Modified: trunk/Source/_javascript_Core/PlatformPlayStation.cmake (289778 => 289779)
--- trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-02-15 00:05:24 UTC (rev 289778)
+++ trunk/Source/_javascript_Core/PlatformPlayStation.cmake 2022-02-15 00:09:10 UTC (rev 289779)
@@ -40,4 +40,6 @@
)
# This overrides the default x64 value of 1GB for the memory pool size
-add_definitions(-DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=64)
+list(APPEND _javascript_Core_PRIVATE_DEFINITIONS
+ FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=64
+)
Modified: trunk/Source/_javascript_Core/PlatformWPE.cmake (289778 => 289779)
--- trunk/Source/_javascript_Core/PlatformWPE.cmake 2022-02-15 00:05:24 UTC (rev 289778)
+++ trunk/Source/_javascript_Core/PlatformWPE.cmake 2022-02-15 00:09:10 UTC (rev 289779)
@@ -10,10 +10,12 @@
${GLIB_INCLUDE_DIRS}
)
+list(APPEND _javascript_Core_PRIVATE_DEFINITIONS
+ JSC_COMPILATION
+ PKGLIBDIR="${CMAKE_INSTALL_FULL_LIBDIR}/wpe-webkit-${WPE_API_VERSION}"
+)
+
install(FILES ${_javascript_Core_INSTALLED_HEADERS}
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/wpe-webkit-${WPE_API_VERSION}/jsc"
COMPONENT "Development"
)
-
-add_definitions(-DJSC_COMPILATION)
-add_definitions(-DPKGLIBDIR="${CMAKE_INSTALL_FULL_LIBDIR}/wpe-webkit-${WPE_API_VERSION}")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
