Title: [289795] trunk/Source
- Revision
- 289795
- Author
- [email protected]
- Date
- 2022-02-15 01:07:04 -0800 (Tue, 15 Feb 2022)
Log Message
[GTK][WPE] Inclusion of OpenGLShims.h should not depend on USE(GLX)
https://bugs.webkit.org/show_bug.cgi?id=236593
Reviewed by Michael Catanzaro.
Source/WebCore:
No new tests needed.
* platform/graphics/GLContext.cpp: Remove inclusion of OpenGLShims.h guarded by USE(GLX).
* platform/graphics/GLContext.h: Include OpenGLShims.h as fallback option when neither
USE(LIBEPOXY) nor USE(OPENGL_ES) are into effect.
Source/WebKit:
* UIProcess/API/glib/WebKitProtocolHandler.cpp: Move inclusion of GL/glx.h under a
PLATFORM(X11) guard, and inclusion of WebCore/OpenGLShims.h into a chain of guards
which picks it if USE(LIBEPOXY) and USE(OPENGL_ES) are both false, which is the same
checks done in other parts of the code where these are needed.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289794 => 289795)
--- trunk/Source/WebCore/ChangeLog 2022-02-15 09:04:27 UTC (rev 289794)
+++ trunk/Source/WebCore/ChangeLog 2022-02-15 09:07:04 UTC (rev 289795)
@@ -1,3 +1,16 @@
+2022-02-15 Adrian Perez de Castro <[email protected]>
+
+ [GTK][WPE] Inclusion of OpenGLShims.h should not depend on USE(GLX)
+ https://bugs.webkit.org/show_bug.cgi?id=236593
+
+ Reviewed by Michael Catanzaro.
+
+ No new tests needed.
+
+ * platform/graphics/GLContext.cpp: Remove inclusion of OpenGLShims.h guarded by USE(GLX).
+ * platform/graphics/GLContext.h: Include OpenGLShims.h as fallback option when neither
+ USE(LIBEPOXY) nor USE(OPENGL_ES) are into effect.
+
2022-02-15 Gabriel Nava Marino <[email protected]>
null ptr deref in WebCore::HTMLModelElement::enterFullscreen()
Modified: trunk/Source/WebCore/platform/graphics/GLContext.cpp (289794 => 289795)
--- trunk/Source/WebCore/platform/graphics/GLContext.cpp 2022-02-15 09:04:27 UTC (rev 289794)
+++ trunk/Source/WebCore/platform/graphics/GLContext.cpp 2022-02-15 09:07:04 UTC (rev 289795)
@@ -31,7 +31,6 @@
#if USE(GLX)
#include "GLContextGLX.h"
-#include "OpenGLShims.h"
#endif
namespace WebCore {
Modified: trunk/Source/WebCore/platform/graphics/GLContext.h (289794 => 289795)
--- trunk/Source/WebCore/platform/graphics/GLContext.h 2022-02-15 09:04:27 UTC (rev 289794)
+++ trunk/Source/WebCore/platform/graphics/GLContext.h 2022-02-15 09:07:04 UTC (rev 289795)
@@ -28,6 +28,8 @@
#include <epoxy/gl.h>
#elif USE(OPENGL_ES)
#include <GLES2/gl2.h>
+#else
+#include "OpenGLShims.h"
#endif
#if USE(EGL) && !PLATFORM(GTK)
Modified: trunk/Source/WebKit/ChangeLog (289794 => 289795)
--- trunk/Source/WebKit/ChangeLog 2022-02-15 09:04:27 UTC (rev 289794)
+++ trunk/Source/WebKit/ChangeLog 2022-02-15 09:07:04 UTC (rev 289795)
@@ -1,3 +1,15 @@
+2022-02-15 Adrian Perez de Castro <[email protected]>
+
+ [GTK][WPE] Inclusion of OpenGLShims.h should not depend on USE(GLX)
+ https://bugs.webkit.org/show_bug.cgi?id=236593
+
+ Reviewed by Michael Catanzaro.
+
+ * UIProcess/API/glib/WebKitProtocolHandler.cpp: Move inclusion of GL/glx.h under a
+ PLATFORM(X11) guard, and inclusion of WebCore/OpenGLShims.h into a chain of guards
+ which picks it if USE(LIBEPOXY) and USE(OPENGL_ES) are both false, which is the same
+ checks done in other parts of the code where these are needed.
+
2022-02-14 Kimmo Kinnunen <[email protected]>
ExtensionsGL is not useful class, it should be removed
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp (289794 => 289795)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp 2022-02-15 09:04:27 UTC (rev 289794)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp 2022-02-15 09:07:04 UTC (rev 289795)
@@ -53,10 +53,17 @@
#if PLATFORM(X11)
#include <WebCore/PlatformDisplayX11.h>
+#if USE(GLX)
+#include <GL/glx.h>
#endif
+#endif
#if USE(LIBEPOXY)
#include <epoxy/gl.h>
+#elif USE(OPENGL_ES)
+#include <GLES2/gl2.h>
+#else
+#include <WebCore/OpenGLShims.h>
#endif
#if USE(EGL)
@@ -67,11 +74,6 @@
#endif
#endif
-#if USE(GLX)
-#include <GL/glx.h>
-#include <WebCore/OpenGLShims.h>
-#endif
-
#if USE(GSTREAMER)
#include <gst/gst.h>
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
