Title: [289797] trunk/Tools/buildstream
- Revision
- 289797
- Author
- [email protected]
- Date
- 2022-02-15 01:20:20 -0800 (Tue, 15 Feb 2022)
Log Message
[Flatpak SDK] Include a GStreamer DTLS transport bug fix
https://bugs.webkit.org/show_bug.cgi?id=236591
Patch by Philippe Normand <[email protected]> on 2022-02-15
Reviewed by Martin Robinson.
This patch is needed for the GstWebRTC backend.
* elements/sdk/gst-plugins-bad.bst:
* patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/Tools/buildstream/ChangeLog (289796 => 289797)
--- trunk/Tools/buildstream/ChangeLog 2022-02-15 09:18:32 UTC (rev 289796)
+++ trunk/Tools/buildstream/ChangeLog 2022-02-15 09:20:20 UTC (rev 289797)
@@ -1,5 +1,17 @@
2022-02-15 Philippe Normand <[email protected]>
+ [Flatpak SDK] Include a GStreamer DTLS transport bug fix
+ https://bugs.webkit.org/show_bug.cgi?id=236591
+
+ Reviewed by Martin Robinson.
+
+ This patch is needed for the GstWebRTC backend.
+
+ * elements/sdk/gst-plugins-bad.bst:
+ * patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch: Added.
+
+2022-02-15 Philippe Normand <[email protected]>
+
[Flatpak SDK] Update to libnice development snapshot
https://bugs.webkit.org/show_bug.cgi?id=236537
Modified: trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst (289796 => 289797)
--- trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst 2022-02-15 09:18:32 UTC (rev 289796)
+++ trunk/Tools/buildstream/elements/sdk/gst-plugins-bad.bst 2022-02-15 09:20:20 UTC (rev 289797)
@@ -3,6 +3,9 @@
- kind: tar
url: gst_downloads:gst-plugins-bad/gst-plugins-bad-1.20.0.tar.xz
ref: 015b8d4d9a395ebf444d40876867a2034dd3304b3ad48bc3a0dd0c1ee71dc11d
+# To be shipped in 1.20.1.
+- kind: patch
+ path: patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch
build-depends:
- freedesktop-sdk.bst:public-stacks/buildsystem-meson.bst
depends:
Added: trunk/Tools/buildstream/patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch (0 => 289797)
--- trunk/Tools/buildstream/patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch (rev 0)
+++ trunk/Tools/buildstream/patches/gstreamer-0001-dtlstransport-Notify-ICE-transport-property-changes.patch 2022-02-15 09:20:20 UTC (rev 289797)
@@ -0,0 +1,41 @@
+From 5a2e1ecb4d82a28aa735d829eb8ecfaaae34674f Mon Sep 17 00:00:00 2001
+From: Philippe Normand <[email protected]>
+Date: Sat, 12 Feb 2022 10:05:11 +0000
+Subject: [PATCH] dtlstransport: Notify ICE transport property changes
+
+The application might track the underlying ICE transport, so not notifying
+changes might lead to use-after-free issues.
+
+Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1688>
+---
+ .../gst-plugins-bad/gst-libs/gst/webrtc/dtlstransport.c | 9 ++++++++-
+ 1 file changed, 8 insertions(+), 1 deletion(-)
+
+diff --git a/gst-libs/gst/webrtc/dtlstransport.c b/gst-libs/gst/webrtc/dtlstransport.c
+index c401f7f73b..e3d54a0566 100644
+--- a/gst-libs/gst/webrtc/dtlstransport.c
++++ b/gst-libs/gst/webrtc/dtlstransport.c
+@@ -64,12 +64,19 @@ void
+ gst_webrtc_dtls_transport_set_transport (GstWebRTCDTLSTransport * transport,
+ GstWebRTCICETransport * ice)
+ {
++ gboolean notify = FALSE;
++
+ g_return_if_fail (GST_IS_WEBRTC_DTLS_TRANSPORT (transport));
+ g_return_if_fail (GST_IS_WEBRTC_ICE_TRANSPORT (ice));
+
+ GST_OBJECT_LOCK (transport);
+- gst_object_replace ((GstObject **) & transport->transport, GST_OBJECT (ice));
++ notify =
++ gst_object_replace ((GstObject **) & transport->transport,
++ GST_OBJECT (ice));
+ GST_OBJECT_UNLOCK (transport);
++
++ if (notify)
++ g_object_notify (G_OBJECT (transport), "transport");
+ }
+
+ static void
+--
+2.34.1
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
