Title: [289806] trunk/Source/WebCore
- Revision
- 289806
- Author
- [email protected]
- Date
- 2022-02-15 06:22:24 -0800 (Tue, 15 Feb 2022)
Log Message
REGRESSION(r289216): Crash in DocumentTimeline::animationCanBeRemoved
https://bugs.webkit.org/show_bug.cgi?id=236615
<rdar://problem/88943156>
Reviewed by Michael Catanzaro.
Use the default style if we can't obtain one from the target's renderer.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationCanBeRemoved):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (289805 => 289806)
--- trunk/Source/WebCore/ChangeLog 2022-02-15 14:20:26 UTC (rev 289805)
+++ trunk/Source/WebCore/ChangeLog 2022-02-15 14:22:24 UTC (rev 289806)
@@ -1,3 +1,16 @@
+2022-02-15 Antoine Quint <[email protected]>
+
+ REGRESSION(r289216): Crash in DocumentTimeline::animationCanBeRemoved
+ https://bugs.webkit.org/show_bug.cgi?id=236615
+ <rdar://problem/88943156>
+
+ Reviewed by Michael Catanzaro.
+
+ Use the default style if we can't obtain one from the target's renderer.
+
+ * animation/DocumentTimeline.cpp:
+ (WebCore::DocumentTimeline::animationCanBeRemoved):
+
2022-02-15 Carlos Garcia Campos <[email protected]>
[GTK] D-Bus crash atk-bridge
Modified: trunk/Source/WebCore/animation/DocumentTimeline.cpp (289805 => 289806)
--- trunk/Source/WebCore/animation/DocumentTimeline.cpp 2022-02-15 14:20:26 UTC (rev 289805)
+++ trunk/Source/WebCore/animation/DocumentTimeline.cpp 2022-02-15 14:22:24 UTC (rev 289806)
@@ -235,8 +235,11 @@
if (!target || !target->element.isDescendantOf(*m_document))
return false;
- ASSERT(target->renderer());
- auto& style = target->renderer()->style();
+ auto& style = [&]() -> const RenderStyle& {
+ if (auto* renderer = target->renderer())
+ return renderer->style();
+ return RenderStyle::defaultStyle();
+ }();
HashSet<CSSPropertyID> propertiesToMatch;
for (auto cssProperty : keyframeEffect->animatedProperties())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
