Title: [107332] trunk/Source/WebCore
- Revision
- 107332
- Author
- [email protected]
- Date
- 2012-02-09 17:54:43 -0800 (Thu, 09 Feb 2012)
Log Message
FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
https://bugs.webkit.org/show_bug.cgi?id=78291
Reviewed by Dan Bernstein.
m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
because otherwise useSlowRepaints() will return false even though we have to use slow repaints.
I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
called again after m_slowRepaintObjectCount has been incremented.
* page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107331 => 107332)
--- trunk/Source/WebCore/ChangeLog 2012-02-10 01:48:11 UTC (rev 107331)
+++ trunk/Source/WebCore/ChangeLog 2012-02-10 01:54:43 UTC (rev 107332)
@@ -1,3 +1,19 @@
+2012-02-09 Anders Carlsson <[email protected]>
+
+ FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
+ https://bugs.webkit.org/show_bug.cgi?id=78291
+
+ Reviewed by Dan Bernstein.
+
+ m_slowRepaintObjectCount needs to be incremented before calling updateCanBlitOnScrollRecursively(),
+ because otherwise useSlowRepaints() will return false even though we have to use slow repaints.
+
+ I was unable to make a layout test for this because it requires that updateCanBlitOnScrollRecursively() isn't
+ called again after m_slowRepaintObjectCount has been incremented.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::addSlowRepaintObject):
+
2012-02-09 Ojan Vafai <[email protected]>
Remove TreeOrderIterator and iterate over the child boxes directly.
Modified: trunk/Source/WebCore/page/FrameView.cpp (107331 => 107332)
--- trunk/Source/WebCore/page/FrameView.cpp 2012-02-10 01:48:11 UTC (rev 107331)
+++ trunk/Source/WebCore/page/FrameView.cpp 2012-02-10 01:54:43 UTC (rev 107332)
@@ -1328,9 +1328,8 @@
void FrameView::addSlowRepaintObject()
{
- if (!m_slowRepaintObjectCount)
+ if (!m_slowRepaintObjectCount++)
updateCanBlitOnScrollRecursively();
- m_slowRepaintObjectCount++;
}
void FrameView::removeSlowRepaintObject()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
