Title: [289941] branches/safari-613-branch/Source/WTF
- Revision
- 289941
- Author
- [email protected]
- Date
- 2022-02-16 12:16:25 -0800 (Wed, 16 Feb 2022)
Log Message
Apply patch. rdar://problem/87486284
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WTF/ChangeLog (289940 => 289941)
--- branches/safari-613-branch/Source/WTF/ChangeLog 2022-02-16 20:16:23 UTC (rev 289940)
+++ branches/safari-613-branch/Source/WTF/ChangeLog 2022-02-16 20:16:25 UTC (rev 289941)
@@ -1,76 +1,80 @@
-2022-02-07 Russell Epstein <[email protected]>
+2022-02-16 Russell Epstein <[email protected]>
- Cherry-pick r288885. rdar://problem/88591342
+ Apply patch. rdar://problem/87486284
- Enhance sanitizeStackForVM() to assist with crash analysis.
- https://bugs.webkit.org/show_bug.cgi?id=235752
- rdar://81014601
-
- Reviewed by Michael Saboff.
-
- Source/_javascript_Core:
-
- 1. Remove the AssemblyHelpers version of sanitizeStack. Instead, make the 3
- JIT operation functions call sanitizeStackForVM() instead. This ensures
- that sanitizeStack crashes are not obscured as generic JIT crashes.
-
- 2. Add sanity check RELEASE_ASSERTs to VM::setLastStackTop() with a capture of
- the relevant variables for crash analysis.
-
- 3. Fix logSanitizeStack() so that it no longer relies on vm.topCallFrame.
- vm.topCallFrame may not be properly initialized at all the places that
- sanitizeStackForVM() is called.
-
- 4. Add a JSLock check to sanitizeStackForVM(), and return early if not owned by
- the current thread. If the JSLock is not owned by the current thread, we can't
- rely on vm.lastStackTop() being a sane value. Hence, it's not possible to
- do stack sanitization correctly.
-
- Add sanity check RELEASE_ASSERTs to sanitizeStackForVM() with a capture of
- the relevant variables for crash analysis.
-
- * jit/AssemblyHelpers.cpp:
- (JSC::AssemblyHelpers::sanitizeStackInline): Deleted.
- * jit/AssemblyHelpers.h:
- * jit/JITOperations.cpp:
- (JSC::JSC_DEFINE_JIT_OPERATION):
- * jit/ThunkGenerators.cpp:
- (JSC::slowPathFor):
- * runtime/JSLock.cpp:
- (JSC::JSLock::didAcquireLock):
- (JSC::JSLock::grabAllLocks):
- * runtime/VM.cpp:
- (JSC::VM::VM):
- (JSC::VM::setLastStackTop):
- (JSC::logSanitizeStack):
- (JSC::sanitizeStackForVM):
- * runtime/VM.h:
-
- Source/WTF:
-
- * wtf/Threading.h:
- (WTF::Thread::savedStackPointerAtVMEntry const):
- (WTF::Thread::savedLastStackTop const):
- (WTF::Thread::savedStackPointerAtVMEntry): Deleted.
- (WTF::Thread::savedLastStackTop): Deleted.
-
-
- git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+ 2022-02-07 Russell Epstein <[email protected]>
- 2022-02-01 Mark Lam <[email protected]>
+ Cherry-pick r288885. rdar://problem/88591342
- Enhance sanitizeStackForVM() to assist with crash analysis.
- https://bugs.webkit.org/show_bug.cgi?id=235752
- rdar://81014601
+ Enhance sanitizeStackForVM() to assist with crash analysis.
+ https://bugs.webkit.org/show_bug.cgi?id=235752
+ rdar://81014601
- Reviewed by Michael Saboff.
+ Reviewed by Michael Saboff.
- * wtf/Threading.h:
- (WTF::Thread::savedStackPointerAtVMEntry const):
- (WTF::Thread::savedLastStackTop const):
- (WTF::Thread::savedStackPointerAtVMEntry): Deleted.
- (WTF::Thread::savedLastStackTop): Deleted.
+ Source/_javascript_Core:
+ 1. Remove the AssemblyHelpers version of sanitizeStack. Instead, make the 3
+ JIT operation functions call sanitizeStackForVM() instead. This ensures
+ that sanitizeStack crashes are not obscured as generic JIT crashes.
+
+ 2. Add sanity check RELEASE_ASSERTs to VM::setLastStackTop() with a capture of
+ the relevant variables for crash analysis.
+
+ 3. Fix logSanitizeStack() so that it no longer relies on vm.topCallFrame.
+ vm.topCallFrame may not be properly initialized at all the places that
+ sanitizeStackForVM() is called.
+
+ 4. Add a JSLock check to sanitizeStackForVM(), and return early if not owned by
+ the current thread. If the JSLock is not owned by the current thread, we can't
+ rely on vm.lastStackTop() being a sane value. Hence, it's not possible to
+ do stack sanitization correctly.
+
+ Add sanity check RELEASE_ASSERTs to sanitizeStackForVM() with a capture of
+ the relevant variables for crash analysis.
+
+ * jit/AssemblyHelpers.cpp:
+ (JSC::AssemblyHelpers::sanitizeStackInline): Deleted.
+ * jit/AssemblyHelpers.h:
+ * jit/JITOperations.cpp:
+ (JSC::JSC_DEFINE_JIT_OPERATION):
+ * jit/ThunkGenerators.cpp:
+ (JSC::slowPathFor):
+ * runtime/JSLock.cpp:
+ (JSC::JSLock::didAcquireLock):
+ (JSC::JSLock::grabAllLocks):
+ * runtime/VM.cpp:
+ (JSC::VM::VM):
+ (JSC::VM::setLastStackTop):
+ (JSC::logSanitizeStack):
+ (JSC::sanitizeStackForVM):
+ * runtime/VM.h:
+
+ Source/WTF:
+
+ * wtf/Threading.h:
+ (WTF::Thread::savedStackPointerAtVMEntry const):
+ (WTF::Thread::savedLastStackTop const):
+ (WTF::Thread::savedStackPointerAtVMEntry): Deleted.
+ (WTF::Thread::savedLastStackTop): Deleted.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-02-01 Mark Lam <[email protected]>
+
+ Enhance sanitizeStackForVM() to assist with crash analysis.
+ https://bugs.webkit.org/show_bug.cgi?id=235752
+ rdar://81014601
+
+ Reviewed by Michael Saboff.
+
+ * wtf/Threading.h:
+ (WTF::Thread::savedStackPointerAtVMEntry const):
+ (WTF::Thread::savedLastStackTop const):
+ (WTF::Thread::savedStackPointerAtVMEntry): Deleted.
+ (WTF::Thread::savedLastStackTop): Deleted.
+
2022-02-07 Russell Epstein <[email protected]>
Cherry-pick r288831. rdar://problem/88268450
@@ -210,6 +214,15 @@
Make input-security a disabled-by-default experimental feature.
+2022-02-16 Keith Miller <[email protected]>
+
+
+ Disable some options that don't need to be on.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+ * wtf/PlatformEnableCocoa.h:
+ * wtf/PlatformHave.h
+
2022-01-28 Russell Epstein <[email protected]>
Cherry-pick r287961. rdar://problem/86282584
Modified: branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml (289940 => 289941)
--- branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-02-16 20:16:23 UTC (rev 289940)
+++ branches/safari-613-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-02-16 20:16:25 UTC (rev 289941)
@@ -1606,11 +1606,11 @@
condition: ENABLE(NOTIFICATIONS)
defaultValue:
WebKitLegacy:
- default: true
+ default: false
WebKit:
- default: true
+ default: false
WebCore:
- default: true
+ default: false
OfflineWebApplicationCacheEnabled:
type: bool
Modified: branches/safari-613-branch/Source/WTF/wtf/PlatformEnableCocoa.h (289940 => 289941)
--- branches/safari-613-branch/Source/WTF/wtf/PlatformEnableCocoa.h 2022-02-16 20:16:23 UTC (rev 289940)
+++ branches/safari-613-branch/Source/WTF/wtf/PlatformEnableCocoa.h 2022-02-16 20:16:25 UTC (rev 289941)
@@ -139,7 +139,7 @@
#define ENABLE_AVF_CAPTIONS 1
#endif
-#if !defined(ENABLE_BUILT_IN_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS))
+#if !defined(ENABLE_BUILT_IN_NOTIFICATIONS) && (PLATFORM(MAC))
#define ENABLE_BUILT_IN_NOTIFICATIONS 1
#endif
@@ -438,7 +438,7 @@
#define ENABLE_NON_VISIBLE_WEBPROCESS_MEMORY_CLEANUP_TIMER 1
#endif
-#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC) || PLATFORM(IOS))
+#if !defined(ENABLE_NOTIFICATIONS) && (PLATFORM(MAC))
#define ENABLE_NOTIFICATIONS 1
#endif
Modified: branches/safari-613-branch/Source/WTF/wtf/PlatformHave.h (289940 => 289941)
--- branches/safari-613-branch/Source/WTF/wtf/PlatformHave.h 2022-02-16 20:16:23 UTC (rev 289940)
+++ branches/safari-613-branch/Source/WTF/wtf/PlatformHave.h 2022-02-16 20:16:25 UTC (rev 289941)
@@ -859,8 +859,8 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000) \
|| ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000)
#if !defined(HAVE_CORE_ANIMATION_SEPARATED_LAYERS)
-#define HAVE_CORE_ANIMATION_SEPARATED_LAYERS 1
-#define HAVE_CORE_ANIMATION_SEPARATED_PORTALS 1
+#define HAVE_CORE_ANIMATION_SEPARATED_LAYERS 0
+#define HAVE_CORE_ANIMATION_SEPARATED_PORTALS 0
#endif
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
