Title: [290197] trunk
- Revision
- 290197
- Author
- n...@apple.com
- Date
- 2022-02-18 20:27:39 -0800 (Fri, 18 Feb 2022)
Log Message
Stop propagating inertness through iframes in Node::deprecatedIsInert()
https://bugs.webkit.org/show_bug.cgi?id=236512
Reviewed by Chris Dumez.
This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
before this bug.
LayoutTests/imported/w3c:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
Source/WebCore:
Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
* dom/Node.cpp:
(WebCore::Node::deprecatedIsInert const):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290196 => 290197)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-19 04:14:04 UTC (rev 290196)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-19 04:27:39 UTC (rev 290197)
@@ -1,5 +1,17 @@
2022-02-18 Tim Nguyen <n...@apple.com>
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ * web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames-expected.txt:
+
+2022-02-18 Tim Nguyen <n...@apple.com>
+
Re-import inert and <dialog> WPT
https://bugs.webkit.org/show_bug.cgi?id=236808
Modified: trunk/Source/WebCore/ChangeLog (290196 => 290197)
--- trunk/Source/WebCore/ChangeLog 2022-02-19 04:14:04 UTC (rev 290196)
+++ trunk/Source/WebCore/ChangeLog 2022-02-19 04:27:39 UTC (rev 290197)
@@ -1,3 +1,18 @@
+2022-02-18 Tim Nguyen <n...@apple.com>
+
+ Stop propagating inertness through iframes in Node::deprecatedIsInert()
+ https://bugs.webkit.org/show_bug.cgi?id=236512
+
+ Reviewed by Chris Dumez.
+
+ This is only a bug for Node::deprecatedIsInert(), so it only affects focus. Selection APIs, etc. weren't affected
+ before this bug.
+
+ Test: web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-focus-in-frames.html
+
+ * dom/Node.cpp:
+ (WebCore::Node::deprecatedIsInert const):
+
2022-02-18 Commit Queue <commit-qu...@webkit.org>
Unreviewed, reverting r290188.
Modified: trunk/Source/WebCore/dom/Node.cpp (290196 => 290197)
--- trunk/Source/WebCore/dom/Node.cpp 2022-02-19 04:14:04 UTC (rev 290196)
+++ trunk/Source/WebCore/dom/Node.cpp 2022-02-19 04:27:39 UTC (rev 290197)
@@ -2634,10 +2634,7 @@
}
}
- if (!document().frame() || !document().frame()->ownerElement())
- return false;
-
- return document().frame()->ownerElement()->deprecatedIsInert();
+ return false;
}
template<> ContainerNode* parent<Tree>(const Node& node)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
