Title: [290231] trunk/Source/WebCore
Revision
290231
Author
[email protected]
Date
2022-02-20 10:32:51 -0800 (Sun, 20 Feb 2022)

Log Message

[LFC][IFC] Flip inline block coords for vertical-rl before painting
https://bugs.webkit.org/show_bug.cgi?id=236896

Reviewed by Antti Koivisto.

This is similar to what we do in LegacyInlineElementBox::paint.

* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (290230 => 290231)


--- trunk/Source/WebCore/ChangeLog	2022-02-20 17:54:10 UTC (rev 290230)
+++ trunk/Source/WebCore/ChangeLog	2022-02-20 18:32:51 UTC (rev 290231)
@@ -1,5 +1,17 @@
 2022-02-20  Alan Bujtas  <[email protected]>
 
+        [LFC][IFC] Flip inline block coords for vertical-rl before painting
+        https://bugs.webkit.org/show_bug.cgi?id=236896
+
+        Reviewed by Antti Koivisto.
+
+        This is similar to what we do in LegacyInlineElementBox::paint.
+
+        * layout/integration/LayoutIntegrationLineLayout.cpp:
+        (WebCore::LayoutIntegration::LineLayout::paint):
+
+2022-02-20  Alan Bujtas  <[email protected]>
+
         [IFC][Integration] Enable non-paginated vertical-lr writing mode
         https://bugs.webkit.org/show_bug.cgi?id=236481
         <rdar://problem/89123721>

Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (290230 => 290231)


--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-20 17:54:10 UTC (rev 290230)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp	2022-02-20 18:32:51 UTC (rev 290231)
@@ -699,8 +699,12 @@
 
         if (auto& renderer = m_boxTree.rendererForLayoutBox(box.layoutBox()); is<RenderBox>(renderer) && renderer.isReplacedOrInlineBlock()) {
             auto& renderBox = downcast<RenderBox>(renderer);
-            if (!renderBox.hasSelfPaintingLayer() && paintInfo.shouldPaintWithinRoot(renderBox))
-                renderBox.paintAsInlineBlock(paintInfo, paintOffset);
+            if (!renderBox.hasSelfPaintingLayer() && paintInfo.shouldPaintWithinRoot(renderBox)) {
+                auto visualTopLeft = paintOffset;
+                if (flow().style().isFlippedBlocksWritingMode())
+                    visualTopLeft = flow().flipForWritingModeForChild(renderBox, paintOffset);
+                renderBox.paintAsInlineBlock(paintInfo, visualTopLeft);
+            }
         }
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to