Title: [290292] trunk/Source/WebKit
- Revision
- 290292
- Author
- [email protected]
- Date
- 2022-02-22 01:05:51 -0800 (Tue, 22 Feb 2022)
Log Message
NSSharingServicePicker gets deallocated when using the standard share menu item
https://bugs.webkit.org/show_bug.cgi?id=236998
<rdar://problem/89174827>
Reviewed by Wenson Hsieh.
The NSMenuItem should keep the NSSharingServicePicker alive.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::getShareMenuItem):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (290291 => 290292)
--- trunk/Source/WebKit/ChangeLog 2022-02-22 08:47:33 UTC (rev 290291)
+++ trunk/Source/WebKit/ChangeLog 2022-02-22 09:05:51 UTC (rev 290292)
@@ -1,3 +1,16 @@
+2022-02-22 Kate Cheney <[email protected]>
+
+ NSSharingServicePicker gets deallocated when using the standard share menu item
+ https://bugs.webkit.org/show_bug.cgi?id=236998
+ <rdar://problem/89174827>
+
+ Reviewed by Wenson Hsieh.
+
+ The NSMenuItem should keep the NSSharingServicePicker alive.
+
+ * UIProcess/mac/WebContextMenuProxyMac.mm:
+ (WebKit::WebContextMenuProxyMac::getShareMenuItem):
+
2022-02-22 Carlos Garcia Campos <[email protected]>
[GTK][WPE] Suspend web process after some time in the process cache
Modified: trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm (290291 => 290292)
--- trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2022-02-22 08:47:33 UTC (rev 290291)
+++ trunk/Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm 2022-02-22 09:05:51 UTC (rev 290292)
@@ -416,6 +416,7 @@
auto sharingServicePicker = adoptNS([[NSSharingServicePicker alloc] initWithItems:items.get()]);
if ([sharingServicePicker respondsToSelector:@selector(standardShareMenuItem)]) {
NSMenuItem *shareMenuItem = [sharingServicePicker standardShareMenuItem];
+ [shareMenuItem setRepresentedObject:sharingServicePicker.get()];
shareMenuItem.identifier = _WKMenuItemIdentifierShareMenu;
completionHandler(shareMenuItem);
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
