Title: [290309] trunk/Source/WebCore
- Revision
- 290309
- Author
- [email protected]
- Date
- 2022-02-22 09:05:59 -0800 (Tue, 22 Feb 2022)
Log Message
AX: Fix accessibility/aria-current-state-changed-notification.html in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=237014
Reviewed by Chris Fleizach.
We need to update AXPropertyName::CurrentValue when we get a AXCurrentStateChanged notification.
Fixes accessibility/aria-current-state-changed-notification.html in isolated tree mode.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
* accessibility/isolatedtree/AXIsolatedTree.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (290308 => 290309)
--- trunk/Source/WebCore/ChangeLog 2022-02-22 16:08:15 UTC (rev 290308)
+++ trunk/Source/WebCore/ChangeLog 2022-02-22 17:05:59 UTC (rev 290309)
@@ -1,3 +1,18 @@
+2022-02-22 Tyler Wilcock <[email protected]>
+
+ AX: Fix accessibility/aria-current-state-changed-notification.html in isolated tree mode
+ https://bugs.webkit.org/show_bug.cgi?id=237014
+
+ Reviewed by Chris Fleizach.
+
+ We need to update AXPropertyName::CurrentValue when we get a AXCurrentStateChanged notification.
+
+ Fixes accessibility/aria-current-state-changed-notification.html in isolated tree mode.
+
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::updateIsolatedTree):
+ * accessibility/isolatedtree/AXIsolatedTree.cpp:
+
2022-02-22 Andres Gonzalez <[email protected]>
Fix for crash in several AX LayoutTests in isolated tree mode.
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (290308 => 290309)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-02-22 16:08:15 UTC (rev 290308)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-02-22 17:05:59 UTC (rev 290309)
@@ -3355,6 +3355,9 @@
case AXCheckedStateChanged:
tree->updateNodeProperty(*notification.first, AXPropertyName::IsChecked);
break;
+ case AXCurrentStateChanged:
+ tree->updateNodeProperty(*notification.first, AXPropertyName::CurrentValue);
+ break;
case AXDisabledStateChanged:
tree->updateNodeProperty(*notification.first, AXPropertyName::CanSetFocusAttribute);
tree->updateNodeProperty(*notification.first, AXPropertyName::IsEnabled);
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (290308 => 290309)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-02-22 16:08:15 UTC (rev 290308)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-02-22 17:05:59 UTC (rev 290309)
@@ -321,6 +321,9 @@
case AXPropertyName::CanSetFocusAttribute:
propertyMap.set(AXPropertyName::CanSetFocusAttribute, axObject.canSetFocusAttribute());
break;
+ case AXPropertyName::CurrentValue:
+ propertyMap.set(AXPropertyName::CurrentValue, axObject.currentValue().isolatedCopy());
+ break;
case AXPropertyName::IsChecked:
propertyMap.set(AXPropertyName::IsChecked, axObject.isChecked());
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
