Title: [290372] trunk/Source/WebCore
Revision
290372
Author
[email protected]
Date
2022-02-23 07:54:52 -0800 (Wed, 23 Feb 2022)

Log Message

REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()
https://bugs.webkit.org/show_bug.cgi?id=235168
<rdar://problem/87518939>

Reviewed by Alexey Proskuryakov.

Use runOnMainThread() from within WebCore, as it will dispatch to the correct thread when
running under iOS/WebKitLegacy.

* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (290371 => 290372)


--- trunk/Source/WebCore/ChangeLog	2022-02-23 15:20:31 UTC (rev 290371)
+++ trunk/Source/WebCore/ChangeLog	2022-02-23 15:54:52 UTC (rev 290372)
@@ -1,3 +1,17 @@
+2022-02-23  Jer Noble  <[email protected]>
+
+        REGRESSION (r287574): ASSERTION FAILED: !m_impl || !m_shouldEnableAssertions || m_impl->wasConstructedOnMainThread() == isMainThread() under WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack()
+        https://bugs.webkit.org/show_bug.cgi?id=235168
+        <rdar://problem/87518939>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Use runOnMainThread() from within WebCore, as it will dispatch to the correct thread when
+        running under iOS/WebKitLegacy.
+
+        * platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
+        (WebCore::AVTrackPrivateAVFObjCImpl::initializeAssetTrack):
+
 2022-02-23  Youenn Fablet  <[email protected]>
 
         RemoteVideoFrameObjectHeap::getVideoFrameBuffer can use base class pixelBuffer accessor

Modified: trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm (290371 => 290372)


--- trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm	2022-02-23 15:20:31 UTC (rev 290371)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm	2022-02-23 15:54:52 UTC (rev 290372)
@@ -87,7 +87,7 @@
         return;
 
     [m_assetTrack loadValuesAsynchronouslyForKeys:assetTrackConfigurationKeyNames() completionHandler:[weakThis = WeakPtr(this)] () mutable {
-        callOnMainRunLoop([weakThis = WTFMove(weakThis)] {
+        callOnMainThread([weakThis = WTFMove(weakThis)] {
             if (weakThis && weakThis->m_audioTrackConfigurationObserver)
                 (*weakThis->m_audioTrackConfigurationObserver)();
             if (weakThis && weakThis->m_videoTrackConfigurationObserver)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to