Diff
Modified: trunk/LayoutTests/ChangeLog (290405 => 290406)
--- trunk/LayoutTests/ChangeLog 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/ChangeLog 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,5 +1,24 @@
2022-02-23 Robert Jenner <[email protected]>
+ Unreviewed, reverting r290351 and r290404.
+
+ Broke the build after revert of initial commit (r290348)
+ Rebases no longer needed due to revert
+
+ Reverted changesets:
+
+ "Use of showModalDialog should appear as a warning in WI
+ console"
+ https://bugs.webkit.org/show_bug.cgi?id=237046
+ https://commits.webkit.org/r290351
+
+ "Use of showModalDialog should appear as a warning in WI
+ console"
+ https://bugs.webkit.org/show_bug.cgi?id=237046
+ https://commits.webkit.org/r290404
+
+2022-02-23 Robert Jenner <[email protected]>
+
Use of showModalDialog should appear as a warning in WI console
https://bugs.webkit.org/show_bug.cgi?id=237046
Modified: trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt (290405 => 290406)
--- trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
Tests that requestAnimationFrame callbacks are not invoked while modal dialogs are displayed.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt (290405 => 290406)
--- trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt (290405 => 290406)
--- trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop.
Modified: trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt (290405 => 290406)
--- trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
Tests that document.cookie returns the right value after a showModalDialog() call
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Modified: trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt (290405 => 290406)
--- trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,3 +1 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
This test passes if it does not print an ALERT with "secret data".
Modified: trunk/LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt (290405 => 290406)
--- trunk/LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,3 +1,2 @@
-CONSOLE MESSAGE: showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead.
This test passes if it does not alert the fail.html's content when clicking the button.
Modified: trunk/Source/WebCore/ChangeLog (290405 => 290406)
--- trunk/Source/WebCore/ChangeLog 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/Source/WebCore/ChangeLog 2022-02-24 01:31:29 UTC (rev 290406)
@@ -1,5 +1,24 @@
2022-02-23 Robert Jenner <[email protected]>
+ Unreviewed, reverting r290351 and r290404.
+
+ Broke the build after revert of initial commit (r290348)
+ Rebases no longer needed due to revert
+
+ Reverted changesets:
+
+ "Use of showModalDialog should appear as a warning in WI
+ console"
+ https://bugs.webkit.org/show_bug.cgi?id=237046
+ https://commits.webkit.org/r290351
+
+ "Use of showModalDialog should appear as a warning in WI
+ console"
+ https://bugs.webkit.org/show_bug.cgi?id=237046
+ https://commits.webkit.org/r290404
+
+2022-02-23 Robert Jenner <[email protected]>
+
Unreviewed, reverting r290348.
Broke a test, slowing down EWS.
Modified: trunk/Source/WebCore/page/DOMWindow.cpp (290405 => 290406)
--- trunk/Source/WebCore/page/DOMWindow.cpp 2022-02-24 01:24:20 UTC (rev 290405)
+++ trunk/Source/WebCore/page/DOMWindow.cpp 2022-02-24 01:31:29 UTC (rev 290406)
@@ -2669,8 +2669,6 @@
void DOMWindow::showModalDialog(const String& urlString, const String& dialogFeaturesString, DOMWindow& activeWindow, DOMWindow& firstWindow, const Function<void(DOMWindow&)>& prepareDialogFunction)
{
- printWarningMessage("showModalDialog() is deprecated and will be removed. Please use the <dialog> element instead."_s);
-
if (!isCurrentlyDisplayedInFrame())
return;
if (!activeWindow.frame())
