Diff
Modified: trunk/Source/WebCore/ChangeLog (290580 => 290581)
--- trunk/Source/WebCore/ChangeLog 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebCore/ChangeLog 2022-02-28 04:17:48 UTC (rev 290581)
@@ -1,3 +1,16 @@
+2022-02-27 Said Abou-Hallawa <[email protected]>
+
+ [GPU Process] Deleted unneeded constructors from DisplayList::Recorder classes
+ https://bugs.webkit.org/show_bug.cgi?id=237261
+
+ Reviewed by Wenson Hsieh.
+
+ This should have been done in r289594.
+
+ * platform/graphics/displaylists/DisplayListRecorder.cpp:
+ (WebCore::DisplayList::Recorder::Recorder):
+ * platform/graphics/displaylists/DisplayListRecorder.h:
+
2022-02-27 Commit Queue <[email protected]>
Unreviewed, reverting r290577.
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (290580 => 290581)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-02-28 04:17:48 UTC (rev 290581)
@@ -48,12 +48,6 @@
m_stateStack.append({ state, initialCTM, initialCTM.mapRect(initialClip) });
}
-Recorder::Recorder(Recorder& parent, const GraphicsContextState& state, const FloatRect& initialClip, const AffineTransform& initialCTM)
- : m_drawGlyphsRecorder(*this, parent.m_drawGlyphsRecorder.deconstructDrawGlyphs())
-{
- m_stateStack.append({ state, initialCTM, initialCTM.mapRect(initialClip) });
-}
-
Recorder::~Recorder()
{
ASSERT(m_stateStack.size() == 1); // If this fires, it indicates mismatched save/restore.
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h (290580 => 290581)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h 2022-02-28 04:17:48 UTC (rev 290581)
@@ -59,8 +59,6 @@
virtual void flushContext(GraphicsContextFlushIdentifier) = 0;
protected:
- WEBCORE_EXPORT Recorder(Recorder& parent, const GraphicsContextState&, const FloatRect& initialClip, const AffineTransform& initialCTM);
-
virtual void recordSave() = 0;
virtual void recordRestore() = 0;
virtual void recordTranslate(float x, float y) = 0;
Modified: trunk/Source/WebKit/ChangeLog (290580 => 290581)
--- trunk/Source/WebKit/ChangeLog 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebKit/ChangeLog 2022-02-28 04:17:48 UTC (rev 290581)
@@ -1,3 +1,13 @@
+2022-02-27 Said Abou-Hallawa <[email protected]>
+
+ [GPU Process] Deleted unneeded constructors from DisplayList::Recorder classes
+ https://bugs.webkit.org/show_bug.cgi?id=237261
+
+ Reviewed by Wenson Hsieh.
+
+ * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
+ * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
+
2022-02-27 Wenson Hsieh <[email protected]>
Invoking "Markup Image" should preserve the existing selection range
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp (290580 => 290581)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp 2022-02-28 04:17:48 UTC (rev 290581)
@@ -52,14 +52,6 @@
{
}
-RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy(RemoteDisplayListRecorderProxy& parent, const FloatRect& initialClip, const AffineTransform& initialCTM)
- : DisplayList::Recorder(parent, { }, initialClip, initialCTM)
- , m_destinationBufferIdentifier(parent.m_destinationBufferIdentifier)
- , m_imageBuffer(parent.m_imageBuffer)
- , m_renderingBackend(parent.m_renderingBackend)
-{
-}
-
void RemoteDisplayListRecorderProxy::convertToLuminanceMask()
{
send(Messages::RemoteDisplayListRecorder::ConvertToLuminanceMask());
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h (290580 => 290581)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h 2022-02-28 04:01:56 UTC (rev 290580)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h 2022-02-28 04:17:48 UTC (rev 290581)
@@ -40,8 +40,6 @@
class RemoteDisplayListRecorderProxy : public WebCore::DisplayList::Recorder {
public:
RemoteDisplayListRecorderProxy(WebCore::ImageBuffer&, RemoteRenderingBackendProxy&, const WebCore::FloatRect& initialClip, const WebCore::AffineTransform&, WebCore::DrawGlyphsRecorder::DeconstructDrawGlyphs = WebCore::DrawGlyphsRecorder::DeconstructDrawGlyphs::Yes);
- RemoteDisplayListRecorderProxy(RemoteDisplayListRecorderProxy& parent, const WebCore::FloatRect& initialClip, const WebCore::AffineTransform& initialCTM);
-
~RemoteDisplayListRecorderProxy() = default;
void resetNeedsFlush() { m_needsFlush = false; }
