Log Message
[GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch https://bugs.webkit.org/show_bug.cgi?id=237202
Reviewed by Adrian Perez de Castro. Source/WebCore: Handle the special case of form item having unknown aria role to be exposed as landmark. * accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::effectiveRole const): LayoutTests: * platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html. * platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (290584 => 290585)
--- trunk/LayoutTests/ChangeLog 2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/ChangeLog 2022-02-28 08:58:55 UTC (rev 290585)
@@ -1,3 +1,13 @@
+2022-02-28 Carlos Garcia Campos <[email protected]>
+
+ [GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
+ https://bugs.webkit.org/show_bug.cgi?id=237202
+
+ Reviewed by Adrian Perez de Castro.
+
+ * platform/gtk/TestExpectations: Remove accessibility/gtk/xml-roles-exposed.html.
+ * platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt: Rebaseline.
+
2022-02-27 Jonathan Bedard <[email protected]>
webkitpy: WebSocket server doesn't support Python 3
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (290584 => 290585)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-28 08:58:55 UTC (rev 290585)
@@ -139,7 +139,6 @@
webkit.org/b/235941 accessibility/gtk/no-notification-for-unrendered-iframe-children.html [ Failure ]
webkit.org/b/235941 accessibility/gtk/text-at-offset-embedded-objects.html [ Failure ]
webkit.org/b/235941 accessibility/gtk/text-at-offset-special-chars.html [ Failure ]
-webkit.org/b/235941 accessibility/gtk/xml-roles-exposed.html [ Failure ]
webkit.org/b/235941 accessibility/gtk/caret-offsets.html [ Timeout ]
# canvas
Modified: trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt (290584 => 290585)
--- trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt 2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/LayoutTests/platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt 2022-02-28 08:58:55 UTC (rev 290585)
@@ -20,7 +20,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live-role:alert, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
+AXPlatformAttributes: atomic:true, computed-role:alert, container-atomic:true, container-live:assertive, container-live-role:alert, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alert
------------
AXRole: AXAlert
AXParent: AXWebArea
@@ -39,7 +39,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: computed-role:alertdialog, container-live-role:alertdialog, container-live:assertive, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
+AXPlatformAttributes: computed-role:alertdialog, container-live:assertive, container-live-role:alertdialog, container-relevant:additions text, live:assertive, relevant:additions text, tag:div, xml-roles:alertdialog
------------
AXRole: AXEmbedded
AXParent: AXWebArea
@@ -438,6 +438,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
+AXURL: (null)
AXPlatformAttributes: computed-role:image, tag:div, xml-roles:img
------------
AXRole: AXInsertion
@@ -496,7 +497,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: computed-role:log, container-live-role:log, container-live:polite, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
+AXPlatformAttributes: computed-role:log, container-live:polite, container-live-role:log, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:log
------------
AXRole: AXLandmarkMain
AXParent: AXWebArea
@@ -534,7 +535,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: computed-role:marquee, container-live-role:marquee, container-live:off, container-relevant:additions text, live:off, relevant:additions text, tag:div, xml-roles:marquee
+AXPlatformAttributes: computed-role:marquee, container-live:off, container-live-role:marquee, container-relevant:additions text, live:off, relevant:additions text, tag:div, xml-roles:marquee
------------
AXRole: AXMath
AXParent: AXWebArea
@@ -620,7 +621,7 @@
AXTitle:
AXDescription:
AXValue:
-AXFocusable: 1
+AXFocusable: 0
AXFocused: 0
AXSelectable: 0
AXSelected: 0
@@ -838,7 +839,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: atomic:true, computed-role:status, container-atomic:true, container-live-role:status, container-live:polite, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:status
+AXPlatformAttributes: atomic:true, computed-role:status, container-atomic:true, container-live:polite, container-live-role:status, container-relevant:additions text, live:polite, relevant:additions text, tag:div, xml-roles:status
------------
AXRole: AXSubscript
AXParent: AXWebArea
@@ -971,7 +972,7 @@
AXExpanded: 0
AXRequired: 0
AXChecked: 0
-AXPlatformAttributes: computed-role:timer, container-live-role:timer, container-live:off, container-relevant:additions text, live:off, relevant:additions text, tag:div, xml-roles:timer
+AXPlatformAttributes: computed-role:timer, container-live:off, container-live-role:timer, container-relevant:additions text, live:off, relevant:additions text, tag:div, xml-roles:timer
------------
AXRole: AXToolbar
AXParent: AXWebArea
@@ -1821,7 +1822,7 @@
AXTitle:
AXDescription:
AXValue: Verify exposure of ARIA role values via the 'xml-roles' object attribute.<\n><\n>On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".<\n><\n><\n>
-AXFocusable: 1
+AXFocusable: 0
AXFocused: 0
AXSelectable: 0
AXSelected: 0
Modified: trunk/Source/WebCore/ChangeLog (290584 => 290585)
--- trunk/Source/WebCore/ChangeLog 2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/Source/WebCore/ChangeLog 2022-02-28 08:58:55 UTC (rev 290585)
@@ -1,3 +1,15 @@
+2022-02-28 Carlos Garcia Campos <[email protected]>
+
+ [GTK][a11y] Test accessibility/gtk/xml-roles-exposed.html is failing since ATSPI switch
+ https://bugs.webkit.org/show_bug.cgi?id=237202
+
+ Reviewed by Adrian Perez de Castro.
+
+ Handle the special case of form item having unknown aria role to be exposed as landmark.
+
+ * accessibility/atspi/AccessibilityObjectAtspi.cpp:
+ (WebCore::AccessibilityObjectAtspi::effectiveRole const):
+
2022-02-28 Antoine Quint <[email protected]>
[web-animations] web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html is a unique failure
Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp (290584 => 290585)
--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp 2022-02-28 08:29:03 UTC (rev 290584)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp 2022-02-28 08:58:55 UTC (rev 290585)
@@ -1223,6 +1223,10 @@
return Atspi::Role::PasswordText;
switch (m_coreObject->roleValue()) {
+ case AccessibilityRole::Form:
+ if (m_coreObject->ariaRoleAttribute() != AccessibilityRole::Unknown)
+ return Atspi::Role::Landmark;
+ break;
case AccessibilityRole::ListMarker: {
auto* renderer = m_coreObject->renderer();
return renderer && renderer->isImage() ? Atspi::Role::Image : Atspi::Role::Text;
@@ -1310,6 +1314,8 @@
return "subscript";
case Atspi::Role::Superscript:
return "superscript";
+ case Atspi::Role::Landmark:
+ return "landmark";
default:
break;
}
@@ -1363,6 +1369,8 @@
return AccessibilityAtspi::localizedRoleName(AccessibilityRole::Subscript);
case Atspi::Role::Superscript:
return AccessibilityAtspi::localizedRoleName(AccessibilityRole::Superscript);
+ case Atspi::Role::Landmark:
+ return AccessibilityAtspi::localizedRoleName(AccessibilityRole::LandmarkMain);
default:
break;
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
