Title: [290597] trunk
- Revision
- 290597
- Author
- [email protected]
- Date
- 2022-02-28 08:32:36 -0800 (Mon, 28 Feb 2022)
Log Message
-Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
https://bugs.webkit.org/show_bug.cgi?id=229867
<rdar://problem/82975115>
Patch by Michael Catanzaro <[email protected]> on 2022-02-28
Reviewed by Carlos Garcia Campos.
Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
locally.
* Source/cmake/WebKitCompilerFlags.cmake:
2022-02-24 Matt Woodrow <[email protected]>
Unreviewed, update my (Matt Woodrow) status to committer.
* metadata/contributors.json:
Modified Paths
Diff
Modified: trunk/ChangeLog (290596 => 290597)
--- trunk/ChangeLog 2022-02-28 15:36:45 UTC (rev 290596)
+++ trunk/ChangeLog 2022-02-28 16:32:36 UTC (rev 290597)
@@ -1,3 +1,16 @@
+2022-02-28 Michael Catanzaro <[email protected]>
+
+ -Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
+ https://bugs.webkit.org/show_bug.cgi?id=229867
+ <rdar://problem/82975115>
+
+ Reviewed by Carlos Garcia Campos.
+
+ Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
+ locally.
+
+ * Source/cmake/WebKitCompilerFlags.cmake:
+
2022-02-24 Matt Woodrow <[email protected]>
Unreviewed, update my (Matt Woodrow) status to committer.
Modified: trunk/Source/cmake/WebKitCompilerFlags.cmake (290596 => 290597)
--- trunk/Source/cmake/WebKitCompilerFlags.cmake 2022-02-28 15:36:45 UTC (rev 290596)
+++ trunk/Source/cmake/WebKitCompilerFlags.cmake 2022-02-28 16:32:36 UTC (rev 290597)
@@ -150,6 +150,12 @@
WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-stringop-overread)
endif ()
+ # -Wodr trips over our bindings integrity feature when LTO is enabled.
+ # https://bugs.webkit.org/show_bug.cgi?id=229867
+ if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+ WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-odr)
+ endif ()
+
# -Wexpansion-to-defined produces false positives with GCC but not Clang
# https://bugs.webkit.org/show_bug.cgi?id=167643#c13
if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
