Title: [290604] trunk
- Revision
- 290604
- Author
- [email protected]
- Date
- 2022-02-28 10:03:12 -0800 (Mon, 28 Feb 2022)
Log Message
Revert r290548
It caused three tests to start failing.
Source/WebCore:
* rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollAnimatorEnabled const): Deleted.
* rendering/RenderLayerScrollableArea.h:
LayoutTests:
* css3/scroll-snap/scroll-padding-overflow-paging.html:
* fast/events/wheelevent-in-scrolling-div.html:
* tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-rtl-with-keyboard.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (290603 => 290604)
--- trunk/LayoutTests/ChangeLog 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/LayoutTests/ChangeLog 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1,3 +1,13 @@
+2022-02-28 Simon Fraser <[email protected]>
+
+ Revert r290548
+
+ It caused three tests to start failing.
+
+ * css3/scroll-snap/scroll-padding-overflow-paging.html:
+ * fast/events/wheelevent-in-scrolling-div.html:
+ * tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-rtl-with-keyboard.html:
+
2022-02-28 Pascal Abresch <[email protected]>
FTP EPLF does not handle directory
Modified: trunk/LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html (290603 => 290604)
--- trunk/LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/LayoutTests/css3/scroll-snap/scroll-padding-overflow-paging.html 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ ScrollAnimatorEnabled=false ] -->
+<!DOCTYPE html>
<html>
<head>
<style>
Modified: trunk/LayoutTests/fast/events/wheelevent-in-scrolling-div.html (290603 => 290604)
--- trunk/LayoutTests/fast/events/wheelevent-in-scrolling-div.html 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/LayoutTests/fast/events/wheelevent-in-scrolling-div.html 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1,4 +1,3 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ ScrollAnimatorEnabled=false ] -->
<html>
<head>
<script src=""
Modified: trunk/LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-rtl-with-keyboard.html (290603 => 290604)
--- trunk/LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-rtl-with-keyboard.html 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-rtl-with-keyboard.html 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ ScrollAnimatorEnabled=false ] -->
+<!DOCTYPE HTML>
<html>
<head>
<style>
Modified: trunk/Source/WebCore/ChangeLog (290603 => 290604)
--- trunk/Source/WebCore/ChangeLog 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/Source/WebCore/ChangeLog 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1,3 +1,13 @@
+2022-02-28 Simon Fraser <[email protected]>
+
+ Revert r290548
+
+ It caused three tests to start failing.
+
+ * rendering/RenderLayerScrollableArea.cpp:
+ (WebCore::RenderLayerScrollableArea::scrollAnimatorEnabled const): Deleted.
+ * rendering/RenderLayerScrollableArea.h:
+
2022-02-28 Antoine Quint <[email protected]>
[web-animations] web-animations/interfaces/Animatable/getAnimations.html is a unique failure
Modified: trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp (290603 => 290604)
--- trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/Source/WebCore/rendering/RenderLayerScrollableArea.cpp 2022-02-28 18:03:12 UTC (rev 290604)
@@ -1542,11 +1542,6 @@
return false;
}
-bool RenderLayerScrollableArea::scrollAnimatorEnabled() const
-{
- return m_layer.page().settings().scrollAnimatorEnabled();
-}
-
void RenderLayerScrollableArea::paintOverlayScrollbars(GraphicsContext& context, const LayoutRect& damageRect, OptionSet<PaintBehavior> paintBehavior, RenderObject* subtreePaintRoot)
{
if (!m_containsDirtyOverlayScrollbars)
Modified: trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h (290603 => 290604)
--- trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h 2022-02-28 18:00:45 UTC (rev 290603)
+++ trunk/Source/WebCore/rendering/RenderLayerScrollableArea.h 2022-02-28 18:03:12 UTC (rev 290604)
@@ -193,7 +193,6 @@
bool isRubberBandInProgress() const final;
bool forceUpdateScrollbarsOnMainThreadForPerformanceTesting() const final;
bool isScrollSnapInProgress() const final;
- bool scrollAnimatorEnabled() const final;
bool mockScrollbarsControllerEnabled() const final;
void logMockScrollbarsControllerMessage(const String&) const final;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
