Title: [290814] trunk/Source/WebKit
Revision
290814
Author
n...@apple.com
Date
2022-03-03 20:40:06 -0800 (Thu, 03 Mar 2022)

Log Message

Allow webpushd to launch browser in background
https://bugs.webkit.org/show_bug.cgi?id=237114

Reviewed by Brady Eidson.

Now that webpushd is sandboxed on Mac (r289566), the LaunchServices SPI call to launch
Safari is now failing, because LaunchServices goes down a different path when there is a
sandboxed caller. In particular, it fails to launch Safari because Safari doesn't register
for the webkit-app-launch scheme. Safari also doesn't want to list this scheme in its plist.

For now, to unblock our testing, we're giving ourselves an entitlement to restore the
pre-sandboxed behavior of being able to launch Safari even though it doesn't register for
the webkit-app-launch scheme. We are still in discussions with LaunchServices and Safari
about if there is a better and more restrictive way of granting ourselves this ability.

* Scripts/process-entitlements.sh:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (290813 => 290814)


--- trunk/Source/WebKit/ChangeLog	2022-03-04 04:08:26 UTC (rev 290813)
+++ trunk/Source/WebKit/ChangeLog	2022-03-04 04:40:06 UTC (rev 290814)
@@ -1,3 +1,22 @@
+2022-03-03  Ben Nham  <n...@apple.com>
+
+        Allow webpushd to launch browser in background
+        https://bugs.webkit.org/show_bug.cgi?id=237114
+
+        Reviewed by Brady Eidson.
+
+        Now that webpushd is sandboxed on Mac (r289566), the LaunchServices SPI call to launch
+        Safari is now failing, because LaunchServices goes down a different path when there is a
+        sandboxed caller. In particular, it fails to launch Safari because Safari doesn't register
+        for the webkit-app-launch scheme. Safari also doesn't want to list this scheme in its plist.
+
+        For now, to unblock our testing, we're giving ourselves an entitlement to restore the
+        pre-sandboxed behavior of being able to launch Safari even though it doesn't register for
+        the webkit-app-launch scheme. We are still in discussions with LaunchServices and Safari
+        about if there is a better and more restrictive way of granting ourselves this ability.
+
+        * Scripts/process-entitlements.sh:
+
 2022-03-03  Devin Rousso  <drou...@apple.com>
 
         [GPU Process] dont load Apple Pay button/logo PDFs in the WebProcess

Modified: trunk/Source/WebKit/Scripts/process-entitlements.sh (290813 => 290814)


--- trunk/Source/WebKit/Scripts/process-entitlements.sh	2022-03-04 04:08:26 UTC (rev 290813)
+++ trunk/Source/WebKit/Scripts/process-entitlements.sh	2022-03-04 04:40:06 UTC (rev 290814)
@@ -222,9 +222,8 @@
 
 function mac_process_webpushd_entitlements()
 {
-    # FIXME: Add a sandbox profile for webpushd.
-    echo "webpushd sandbox has not been implemented yet"
     plistbuddy Add :com.apple.private.aps-connection-initiate bool YES
+    plistbuddy Add :com.apple.private.launchservices.allowopenwithanyhandler bool YES
 }
 
 # ========================================
@@ -513,6 +512,7 @@
     # FIXME: Add a sandbox profile for webpushd and add it to the seatbelt-profiles array.
     echo "webpushd sandbox has not been implemented yet"
     plistbuddy Add :aps-connection-initiate bool YES
+    plistbuddy Add :com.apple.private.launchservices.allowopenwithanyhandler bool YES
 }
 
 function ios_family_process_network_entitlements()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to