Title: [290831] trunk
- Revision
- 290831
- Author
- grao...@webkit.org
- Date
- 2022-03-04 07:42:12 -0800 (Fri, 04 Mar 2022)
Log Message
[web-animations] "inherit" values should trigger keyframe recomputation if any previous effect has changed that property
https://bugs.webkit.org/show_bug.cgi?id=237471
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
* web-platform-tests/web-animations/responsive/textIndent-expected.txt:
Source/WebCore:
When we fixed 237371 we only looked at the unanimated style, but we should account for any previous keyframe effect
modifying a property set to "inherit" for the current effect.
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::applyKeyframeEffects):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290830 => 290831)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-04 15:11:44 UTC (rev 290830)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-04 15:42:12 UTC (rev 290831)
@@ -1,3 +1,12 @@
+2022-03-04 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] "inherit" values should trigger keyframe recomputation if any previous effect has changed that property
+ https://bugs.webkit.org/show_bug.cgi?id=237471
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/web-animations/responsive/textIndent-expected.txt:
+
2022-03-02 Antoine Quint <grao...@webkit.org>
[web-animations] keyframe values set to "inherit" should recompute their values when the inherited value changes
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/textIndent-expected.txt (290830 => 290831)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/textIndent-expected.txt 2022-03-04 15:11:44 UTC (rev 290830)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/textIndent-expected.txt 2022-03-04 15:42:12 UTC (rev 290831)
@@ -1,4 +1,4 @@
PASS textIndent responsive to style changes
-FAIL textIndent responsive to inherited textIndent changes assert_equals: expected "300px hanging each-line" but got "200px hanging each-line"
+PASS textIndent responsive to inherited textIndent changes
Modified: trunk/Source/WebCore/ChangeLog (290830 => 290831)
--- trunk/Source/WebCore/ChangeLog 2022-03-04 15:11:44 UTC (rev 290830)
+++ trunk/Source/WebCore/ChangeLog 2022-03-04 15:42:12 UTC (rev 290831)
@@ -1,3 +1,16 @@
+2022-03-04 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] "inherit" values should trigger keyframe recomputation if any previous effect has changed that property
+ https://bugs.webkit.org/show_bug.cgi?id=237471
+
+ Reviewed by Antti Koivisto.
+
+ When we fixed 237371 we only looked at the unanimated style, but we should account for any previous keyframe effect
+ modifying a property set to "inherit" for the current effect.
+
+ * animation/KeyframeEffectStack.cpp:
+ (WebCore::KeyframeEffectStack::applyKeyframeEffects):
+
2022-03-04 Kate Cheney <katherine_che...@apple.com>
CSP report does not get sent to the document in the case of a detached element
Modified: trunk/Source/WebCore/animation/KeyframeEffectStack.cpp (290830 => 290831)
--- trunk/Source/WebCore/animation/KeyframeEffectStack.cpp 2022-03-04 15:11:44 UTC (rev 290830)
+++ trunk/Source/WebCore/animation/KeyframeEffectStack.cpp 2022-03-04 15:42:12 UTC (rev 290831)
@@ -147,7 +147,7 @@
auto inheritedPropertyChanged = [&]() {
if (previousLastStyleChangeEventStyle) {
for (auto property : effect->inheritedProperties()) {
- if (!CSSPropertyAnimation::propertiesEqual(property, *previousLastStyleChangeEventStyle, unanimatedStyle))
+ if (!CSSPropertyAnimation::propertiesEqual(property, *previousLastStyleChangeEventStyle, targetStyle))
return true;
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
