Title: [290847] trunk/Source/WebKit
- Revision
- 290847
- Author
- [email protected]
- Date
- 2022-03-04 14:12:04 -0800 (Fri, 04 Mar 2022)
Log Message
Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
https://bugs.webkit.org/show_bug.cgi?id=237478
<rdar://89072235>
Reviewed by Alan Bujtas.
Crash data show that r290109 failed to fix this crash; the actual cause of the crash is a
null m_page on TiledCoreAnimationScrollingCoordinator, diagnosed by noting that the crash
offset corresponds to the offset of m_renderingUpdateRemainingSteps in Page.
* WebProcess/WebPage/mac/TiledCoreAnimationScrollingCoordinator.mm:
(WebKit::TiledCoreAnimationScrollingCoordinator::hasNodeWithAnimatedScrollChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (290846 => 290847)
--- trunk/Source/WebKit/ChangeLog 2022-03-04 22:10:10 UTC (rev 290846)
+++ trunk/Source/WebKit/ChangeLog 2022-03-04 22:12:04 UTC (rev 290847)
@@ -1,3 +1,18 @@
+2022-03-04 Simon Fraser <[email protected]>
+
+ Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
+ https://bugs.webkit.org/show_bug.cgi?id=237478
+ <rdar://89072235>
+
+ Reviewed by Alan Bujtas.
+
+ Crash data show that r290109 failed to fix this crash; the actual cause of the crash is a
+ null m_page on TiledCoreAnimationScrollingCoordinator, diagnosed by noting that the crash
+ offset corresponds to the offset of m_renderingUpdateRemainingSteps in Page.
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationScrollingCoordinator.mm:
+ (WebKit::TiledCoreAnimationScrollingCoordinator::hasNodeWithAnimatedScrollChanged):
+
2022-03-04 J Pascoe <[email protected]>
[WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationScrollingCoordinator.mm (290846 => 290847)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationScrollingCoordinator.mm 2022-03-04 22:10:10 UTC (rev 290846)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationScrollingCoordinator.mm 2022-03-04 22:12:04 UTC (rev 290847)
@@ -48,11 +48,10 @@
void TiledCoreAnimationScrollingCoordinator::hasNodeWithAnimatedScrollChanged(bool haveAnimatedScrollingNodes)
{
- ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged(haveAnimatedScrollingNodes);
-
if (!m_page)
return;
+ ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged(haveAnimatedScrollingNodes);
m_page->setHasActiveAnimatedScrolls(haveAnimatedScrollingNodes);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
