Diff
Modified: trunk/Source/WebCore/ChangeLog (107431 => 107432)
--- trunk/Source/WebCore/ChangeLog 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/ChangeLog 2012-02-10 21:03:13 UTC (rev 107432)
@@ -1,3 +1,30 @@
+2012-02-10 Kentaro Hara <[email protected]>
+
+ Rename [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor]
+ https://bugs.webkit.org/show_bug.cgi?id=78352
+
+ Reviewed by Adam Barth.
+
+ [JSCustomGetOwnPropertySlotDelegate] is used for "flexibly customizable"
+ named getter. It allows us to write custom code for getOwnPropertySlotDelegate()
+ and getOwnPropertyDescriptorDelegate(). To clarify that, we can rename
+ [JSCustomGetOwnPropertySlotDelegate] to [JSCustomGetOwnPropertySlotAndDescriptor].
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateGetOwnPropertySlotBody):
+ (GenerateGetOwnPropertyDescriptorBody):
+ (GenerateHeader):
+ (GenerateImplementation):
+
+ * html/HTMLAppletElement.idl:
+ * html/HTMLEmbedElement.idl:
+ * html/HTMLObjectElement.idl:
+ * page/History.idl:
+ * page/Location.idl:
+ * workers/WorkerContext.idl:
+
2012-02-10 Anders Carlsson <[email protected]>
Minor ScrollAnimatorMac cleanup
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107431 => 107432)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2012-02-10 21:03:13 UTC (rev 107432)
@@ -469,7 +469,7 @@
&$manualLookupGetterGeneration();
}
- if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
+ if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
push(@getOwnPropertySlotImpl, " if (thisObject->getOwnPropertySlotDelegate(exec, propertyName, slot))\n");
push(@getOwnPropertySlotImpl, " return true;\n");
}
@@ -570,7 +570,7 @@
&$manualLookupGetterGeneration();
}
- if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}) {
+ if ($dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}) {
push(@getOwnPropertyDescriptorImpl, " if (thisObject->getOwnPropertyDescriptorDelegate(exec, propertyName, descriptor))\n");
push(@getOwnPropertyDescriptorImpl, " return true;\n");
}
@@ -758,7 +758,7 @@
|| $dataNode->extendedAttributes->{"IndexedGetter"}
|| $dataNode->extendedAttributes->{"NumericIndexedGetter"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
- || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
+ || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
|| $dataNode->extendedAttributes->{"NamedGetter"}
|| $dataNode->extendedAttributes->{"CustomNamedGetter"};
@@ -767,8 +767,8 @@
push(@headerContent, " static bool getOwnPropertySlot(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertySlot&);\n");
push(@headerContent, " static bool getOwnPropertyDescriptor(JSC::JSObject*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::PropertyDescriptor&);\n");
push(@headerContent, " static bool getOwnPropertySlotByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::PropertySlot&);\n") if ($dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"NumericIndexedGetter"}) && !$dataNode->extendedAttributes->{"CustomNamedGetter"};
- push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
- push(@headerContent, " bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"};
+ push(@headerContent, " bool getOwnPropertySlotDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertySlot&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
+ push(@headerContent, " bool getOwnPropertyDescriptorDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::PropertyDescriptor&);\n") if $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"};
$structureFlags{"JSC::OverridesGetOwnPropertySlot"} = 1;
}
@@ -1623,7 +1623,7 @@
|| !$dataNode->extendedAttributes->{"OmitConstructor"}
|| $dataNode->extendedAttributes->{"IndexedGetter"}
|| $dataNode->extendedAttributes->{"NumericIndexedGetter"}
- || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotDelegate"}
+ || $dataNode->extendedAttributes->{"JSCustomGetOwnPropertySlotAndDescriptor"}
|| $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"}
|| $dataNode->extendedAttributes->{"NamedGetter"}
|| $dataNode->extendedAttributes->{"CustomNamedGetter"};
Modified: trunk/Source/WebCore/html/HTMLAppletElement.idl (107431 => 107432)
--- trunk/Source/WebCore/html/HTMLAppletElement.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/html/HTMLAppletElement.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -22,7 +22,7 @@
interface [
CustomNamedSetter,
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLAppletElement : HTMLElement {
attribute [Reflect] DOMString align;
Modified: trunk/Source/WebCore/html/HTMLEmbedElement.idl (107431 => 107432)
--- trunk/Source/WebCore/html/HTMLEmbedElement.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/html/HTMLEmbedElement.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -22,7 +22,7 @@
interface [
CustomNamedSetter,
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLEmbedElement : HTMLElement {
attribute [Reflect] DOMString align;
Modified: trunk/Source/WebCore/html/HTMLObjectElement.idl (107431 => 107432)
--- trunk/Source/WebCore/html/HTMLObjectElement.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/html/HTMLObjectElement.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -22,7 +22,7 @@
interface [
CustomNamedSetter,
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
CustomCall
] HTMLObjectElement : HTMLElement {
readonly attribute HTMLFormElement form;
Modified: trunk/Source/WebCore/page/History.idl (107431 => 107432)
--- trunk/Source/WebCore/page/History.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/page/History.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -29,7 +29,7 @@
#if defined(V8_BINDING) && V8_BINDING
CheckDomainSecurity,
#endif
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
Modified: trunk/Source/WebCore/page/Location.idl (107431 => 107432)
--- trunk/Source/WebCore/page/Location.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/page/Location.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -32,7 +32,7 @@
#if defined(V8_BINDING) && V8_BINDING
CheckDomainSecurity,
#endif
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
Modified: trunk/Source/WebCore/workers/WorkerContext.idl (107431 => 107432)
--- trunk/Source/WebCore/workers/WorkerContext.idl 2012-02-10 21:00:27 UTC (rev 107431)
+++ trunk/Source/WebCore/workers/WorkerContext.idl 2012-02-10 21:03:13 UTC (rev 107432)
@@ -29,7 +29,7 @@
interface [
Conditional=WORKERS,
JSCustomMarkFunction,
- JSCustomGetOwnPropertySlotDelegate,
+ JSCustomGetOwnPropertySlotAndDescriptor,
EventTarget,
ExtendsDOMGlobalObject,
IsWorkerContext,
