Title: [290860] trunk/Source/WebCore
Revision
290860
Author
tyle...@apple.com
Date
2022-03-04 18:38:44 -0800 (Fri, 04 Mar 2022)

Log Message

AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475

Reviewed by Chris Fleizach.

This is better practice as ascending the hierarchy could cause
the object to get deleted.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (290859 => 290860)


--- trunk/Source/WebCore/ChangeLog	2022-03-05 02:21:44 UTC (rev 290859)
+++ trunk/Source/WebCore/ChangeLog	2022-03-05 02:38:44 UTC (rev 290860)
@@ -1,5 +1,18 @@
 2022-03-04  Tyler Wilcock  <tyle...@apple.com>
 
+        AX: Protect incoming object with Ref in AXObjectCache::textChanged
+        https://bugs.webkit.org/show_bug.cgi?id=237475
+
+        Reviewed by Chris Fleizach.
+
+        This is better practice as ascending the hierarchy could cause
+        the object to get deleted.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::textChanged):
+
+2022-03-04  Tyler Wilcock  <tyle...@apple.com>
+
         AX: [WebAccessibilityObjectWrapperMac AXAttributeStringSetFont] crashes when given a font with a nil postscript name, font family, or display name
         https://bugs.webkit.org/show_bug.cgi?id=237373
 

Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (290859 => 290860)


--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2022-03-05 02:21:44 UTC (rev 290859)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2022-03-05 02:38:44 UTC (rev 290860)
@@ -983,6 +983,7 @@
 
     if (!object)
         return;
+    Ref<AccessibilityObject> protectedObject(*object);
 
     // If this element supports ARIA live regions, or is part of a region with an ARIA editable role,
     // then notify the AT of changes.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to