Title: [107436] trunk/Source/WebCore
Revision
107436
Author
[email protected]
Date
2012-02-10 13:43:22 -0800 (Fri, 10 Feb 2012)

Log Message

Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
https://bugs.webkit.org/show_bug.cgi?id=78353

Reviewed by Adam Barth.

[JSCustomPrototypePutDelegate] is used to write custom code for named
getters on a prototype interface. "PutDelegate" is just a method name
in implementation and not so descriptive. This patch renames it to
[JSCustomNamedGetterOnPrototype]. This is also for naming consistency
with [CustomNamedGetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* page/Location.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (107435 => 107436)


--- trunk/Source/WebCore/ChangeLog	2012-02-10 21:40:02 UTC (rev 107435)
+++ trunk/Source/WebCore/ChangeLog	2012-02-10 21:43:22 UTC (rev 107436)
@@ -1,3 +1,23 @@
+2012-02-10  Kentaro Hara  <[email protected]>
+
+        Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
+        https://bugs.webkit.org/show_bug.cgi?id=78353
+
+        Reviewed by Adam Barth.
+
+        [JSCustomPrototypePutDelegate] is used to write custom code for named
+        getters on a prototype interface. "PutDelegate" is just a method name
+        in implementation and not so descriptive. This patch renames it to
+        [JSCustomNamedGetterOnPrototype]. This is also for naming consistency
+        with [CustomNamedGetter].
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateHeader):
+        (GenerateImplementation):
+        * page/Location.idl:
+
 2012-02-10  Enrica Casucci  <[email protected]>
 
         Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (107435 => 107436)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-10 21:40:02 UTC (rev 107435)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2012-02-10 21:43:22 UTC (rev 107436)
@@ -1048,7 +1048,7 @@
         "    {\n" .
         "        return JSC::Structure::create(globalData, globalObject, prototype, JSC::TypeInfo(JSC::ObjectType, StructureFlags), &s_info);\n" .
         "    }\n");
-    if ($dataNode->extendedAttributes->{"JSCustomPrototypePutDelegate"}) {
+    if ($dataNode->extendedAttributes->{"JSCustomNamedGetterOnPrototype"}) {
         push(@headerContent, "    static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
         push(@headerContent, "    bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n");
     }
@@ -1517,7 +1517,7 @@
         push(@implContent, "}\n\n");
     }
 
-    if ($dataNode->extendedAttributes->{"JSCustomPrototypePutDelegate"}) {
+    if ($dataNode->extendedAttributes->{"JSCustomNamedGetterOnPrototype"}) {
         push(@implContent, "void ${className}Prototype::put(JSCell* cell, ExecState* exec, const Identifier& propertyName, JSValue value, PutPropertySlot& slot)\n");
         push(@implContent, "{\n");
         push(@implContent, "    ${className}Prototype* thisObject = jsCast<${className}Prototype*>(cell);\n");

Modified: trunk/Source/WebCore/page/Location.idl (107435 => 107436)


--- trunk/Source/WebCore/page/Location.idl	2012-02-10 21:40:02 UTC (rev 107435)
+++ trunk/Source/WebCore/page/Location.idl	2012-02-10 21:43:22 UTC (rev 107436)
@@ -38,7 +38,7 @@
         CustomDeleteProperty,
         CustomEnumerateProperty,
         JSCustomDefineOwnProperty,
-        JSCustomPrototypePutDelegate,
+        JSCustomNamedGetterOnPrototype,
         JSCustomPrototypeDefineOwnProperty,
         OmitConstructor
     ] Location {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to