Title: [290892] trunk/Source
- Revision
- 290892
- Author
- [email protected]
- Date
- 2022-03-07 09:29:22 -0800 (Mon, 07 Mar 2022)
Log Message
Small cleanups of media code
https://bugs.webkit.org/show_bug.cgi?id=237496
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
No new tests. No behavior change.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updatePlayState): `schedulePlaybackControlsManagerUpdate()` is
called in both branches.
Source/WebKit:
* WebProcess/cocoa/PlaybackSessionManager.h: `protected` is not needed here.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (290891 => 290892)
--- trunk/Source/WebCore/ChangeLog 2022-03-07 17:13:17 UTC (rev 290891)
+++ trunk/Source/WebCore/ChangeLog 2022-03-07 17:29:22 UTC (rev 290892)
@@ -1,3 +1,16 @@
+2022-03-07 Peng Liu <[email protected]>
+
+ Small cleanups of media code
+ https://bugs.webkit.org/show_bug.cgi?id=237496
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ No new tests. No behavior change.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::updatePlayState): `schedulePlaybackControlsManagerUpdate()` is
+ called in both branches.
+
2022-03-07 Antoine Quint <[email protected]>
[web-animations] text-emphasis-style should support discrete animations
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (290891 => 290892)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-03-07 17:13:17 UTC (rev 290891)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-03-07 17:29:22 UTC (rev 290892)
@@ -5622,9 +5622,8 @@
#endif
}
+ schedulePlaybackControlsManagerUpdate();
if (shouldBePlaying) {
- schedulePlaybackControlsManagerUpdate();
-
invalidateCachedTime();
if (playerPaused) {
@@ -5649,8 +5648,6 @@
startPlaybackProgressTimer();
setPlaying(true);
} else {
- schedulePlaybackControlsManagerUpdate();
-
if (!playerPaused)
pausePlayer();
refreshCachedTime();
Modified: trunk/Source/WebKit/ChangeLog (290891 => 290892)
--- trunk/Source/WebKit/ChangeLog 2022-03-07 17:13:17 UTC (rev 290891)
+++ trunk/Source/WebKit/ChangeLog 2022-03-07 17:29:22 UTC (rev 290892)
@@ -1,3 +1,12 @@
+2022-03-07 Peng Liu <[email protected]>
+
+ Small cleanups of media code
+ https://bugs.webkit.org/show_bug.cgi?id=237496
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * WebProcess/cocoa/PlaybackSessionManager.h: `protected` is not needed here.
+
2022-03-07 Adrian Perez de Castro <[email protected]>
[GTK] generate-automation-atom.py breaks reproducible builds
Modified: trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h (290891 => 290892)
--- trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h 2022-03-07 17:13:17 UTC (rev 290891)
+++ trunk/Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h 2022-03-07 17:29:22 UTC (rev 290892)
@@ -110,7 +110,7 @@
WebCore::HTMLMediaElement* currentPlaybackControlsElement() const;
-protected:
+private:
friend class PlaybackSessionInterfaceContext;
friend class VideoFullscreenManager;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
