Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290896 => 290897)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-07 18:00:31 UTC (rev 290896)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-07 18:18:39 UTC (rev 290897)
@@ -1,5 +1,15 @@
2022-03-07 Antoine Quint <[email protected]>
+ Transition on text-decoration-color from currentColor jumps
+ https://bugs.webkit.org/show_bug.cgi?id=236992
+ <rdar://problem/89382835>
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/web-animations/responsive/to-color-change-expected.txt:
+
+2022-03-07 Antoine Quint <[email protected]>
+
[web-animations] text-emphasis shorthand should be animatable
https://bugs.webkit.org/show_bug.cgi?id=237529
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt (290896 => 290897)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt 2022-03-07 18:00:31 UTC (rev 290896)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/responsive/to-color-change-expected.txt 2022-03-07 18:18:39 UTC (rev 290897)
@@ -6,7 +6,7 @@
PASS Border color responsive to currentColor changes again
PASS Outline color responsive to currentColor changes
FAIL Stroke color responsive to currentColor changes assert_equals: expected "rgb(0, 34, 102)" but got "none"
-FAIL Text decoration color responsive to currentColor changes assert_equals: expected "rgb(0, 34, 102)" but got "rgba(0, 68, 0, 0.5)"
+PASS Text decoration color responsive to currentColor changes
FAIL Color responsive to parent currentColor changes assert_equals: expected "rgb(34, 51, 34)" but got "rgb(0, 51, 51)"
FAIL Color responsive to repeated parent currentColor changes assert_equals: expected "rgb(102, 17, 51)" but got "rgb(0, 17, 153)"
PASS Color animations do not expose visited status
Modified: trunk/Source/WebCore/ChangeLog (290896 => 290897)
--- trunk/Source/WebCore/ChangeLog 2022-03-07 18:00:31 UTC (rev 290896)
+++ trunk/Source/WebCore/ChangeLog 2022-03-07 18:18:39 UTC (rev 290897)
@@ -1,5 +1,18 @@
2022-03-07 Antoine Quint <[email protected]>
+ Transition on text-decoration-color from currentColor jumps
+ https://bugs.webkit.org/show_bug.cgi?id=236992
+ <rdar://problem/89382835>
+
+ Reviewed by Antti Koivisto.
+
+ We need to use the MaybeInvalidColor tag to identify that this property can work with `currentColor`.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
+2022-03-07 Antoine Quint <[email protected]>
+
[web-animations] text-emphasis shorthand should be animatable
https://bugs.webkit.org/show_bug.cgi?id=237529
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (290896 => 290897)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-07 18:00:31 UTC (rev 290896)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-07 18:18:39 UTC (rev 290897)
@@ -2696,7 +2696,7 @@
new PropertyWrapperFontStyle(),
new PropertyWrapper<TextDecorationThickness>(CSSPropertyTextDecorationThickness, &RenderStyle::textDecorationThickness, &RenderStyle::setTextDecorationThickness),
new PropertyWrapper<TextUnderlineOffset>(CSSPropertyTextUnderlineOffset, &RenderStyle::textUnderlineOffset, &RenderStyle::setTextUnderlineOffset),
- new PropertyWrapperVisitedAffectedColor(CSSPropertyTextDecorationColor, &RenderStyle::textDecorationColor, &RenderStyle::setTextDecorationColor, &RenderStyle::visitedLinkTextDecorationColor, &RenderStyle::setVisitedLinkTextDecorationColor),
+ new PropertyWrapperVisitedAffectedColor(CSSPropertyTextDecorationColor, MaybeInvalidColor, &RenderStyle::textDecorationColor, &RenderStyle::setTextDecorationColor, &RenderStyle::visitedLinkTextDecorationColor, &RenderStyle::setVisitedLinkTextDecorationColor),
new LengthPropertyWrapper(CSSPropertyFlexBasis, &RenderStyle::flexBasis, &RenderStyle::setFlexBasis, { LengthPropertyWrapper::Flags::IsLengthPercentage, LengthPropertyWrapper::Flags::NegativeLengthsAreInvalid }),
new FloatPropertyWrapper(CSSPropertyFlexGrow, &RenderStyle::flexGrow, &RenderStyle::setFlexGrow, FloatPropertyWrapper::ValueRange::NonNegative),
